Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated typing. TS stdlib provides enough for e2e tests #637

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Jun 5, 2016

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2016
@devversion
Copy link
Member

@hansl As seen in #631, can we not use the typings manager here and remove the static typings?

@hansl
Copy link
Contributor Author

hansl commented Jun 6, 2016

We'll just skip typings and go directly to @types when TS 2.0 is released.

@hansl
Copy link
Contributor Author

hansl commented Jun 6, 2016

R: @jelbourn

@jelbourn
Copy link
Member

jelbourn commented Jun 6, 2016

LGTM

@jelbourn jelbourn merged commit a68597e into angular:master Jun 6, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants