Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding ripples to button-toggle #9442

Closed
devversion opened this issue Jan 17, 2018 · 1 comment · Fixed by #9891
Closed

Consider adding ripples to button-toggle #9442

devversion opened this issue Jan 17, 2018 · 1 comment · Fixed by #9891
Assignees
@devversion
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix target: major This PR is targeted for the next major release
Milestone
6.0

Comments

@devversion
Copy link
Member

We might want to add ripples to button-toggle in the next major version.

Technically they are listed under the buttons section of the Material Design specs, which means that they should have ripples for each individual button.
@devversion devversion added the target: major This PR is targeted for the next major release label Jan 17, 2018
@devversion devversion self-assigned this Jan 17, 2018
@devversion devversion added this to the 6.0 milestone Jan 17, 2018
@devversion devversion added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Jan 27, 2018
devversion added a commit to devversion/material2 that referenced this issue Feb 11, 2018
@devversion
feat: add ripples to button-toggle
4de6463 
* Adds ripples to the `MatButtonToggle` component
* Fixes that the focus overlay for button toggles shows on mouse/touch press.
* Properly stops monitoring through the `FocusMonitor` on component destroy.
* Removes unnecessary mixin for focus-overlay color. Color can be always set, because the overlay will be toggled through `opacity` (performance improvement)

Closes angular#9442
@devversion devversion mentioned this issue Feb 11, 2018
Merged
jelbourn pushed a commit that referenced this issue Feb 12, 2018
@devversion @jelbourn
feat: add ripples to button-toggle
b500c54 
* Adds ripples to the `MatButtonToggle` component
* Fixes that the focus overlay for button toggles shows on mouse/touch press.
* Properly stops monitoring through the `FocusMonitor` on component destroy.
* Removes unnecessary mixin for focus-overlay color. Color can be always set, because the overlay will be toggled through `opacity` (performance improvement)

Closes #9442
jelbourn pushed a commit that referenced this issue Feb 13, 2018
@devversion @jelbourn
feat: add ripples to button-toggle (#9891)
53417d4 
* Adds ripples to the `MatButtonToggle` component
* Fixes that the focus overlay for button toggles shows on mouse/touch press.
* Properly stops monitoring through the `FocusMonitor` on component destroy.
* Removes unnecessary mixin for focus-overlay color. Color can be always set, because the overlay will be toggled through `opacity` (performance improvement)

Closes #9442
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix target: major This PR is targeted for the next major release
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

feat: add ripples to button-toggle devversion/material2
1 participant
@devversion