feat: add ripples to button-toggle #9891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds ripples to the `MatButtonToggle` component * Fixes that the focus overlay for button toggles shows on mouse/touch press. * Properly stops monitoring through the `FocusMonitor` on component destroy. * Removes unnecessary mixin for focus-overlay color. Color can be always set, because the overlay will be toggled through `opacity` (performance improvement) Closes angular#9442
devversion
added
pr: needs review
target: major
googlebot
added
the
cla: yes
crisbeto
approved these changes
Feb 11, 2018
| expect(groupElement.querySelectorAll('.mat-ripple-element').length).toBe(1); | ||
| }); | ||
|
|
||
| it('should allow disabling ripples', () => { |
There was a problem hiding this comment.
"should allow ripples to be disabled"
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatButtonTogglecomponentFocusMonitoron component destroy.opacity(performance improvement)Closes #9442