Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): fixed tabs #1356

Closed
wants to merge 204 commits into from
Closed

feat(tabs): fixed tabs #1356

wants to merge 204 commits into from

Conversation

dasois
Copy link
Contributor

@dasois dasois commented Sep 28, 2016

Fixed tabs grow until they fill the tab group.

Closes #1353

Fixed tabs grow until they fill the tab group.

Closes #1353
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 28, 2016
jelbourn and others added 28 commits September 28, 2016 15:23
* chore: fix CI flakiness by using correct build targets

* wip flaky fix

* fix inline build

* fix typo
Fixes the snack bar not being readable in the cases where `box-sizing: border-box` is applied globally.

Fixes #1412.
* Currently the asterisk is still using the warn color when the input is not focused anymore.

* Per Material Specs the asterisk should be only red when the input is focused (https://material-design.storage.googleapis.com/publish/material_v_9/0B7WCemMG6e0VcHFla0dwOE5pVVE/forms-supportive-content-v3_xhdpi.webm)

Fixes #1395.
Tabs on mobile devices have a min-width of 72px.

Closes #1350
* The aria-target attribute is a non-existing attribute (also confirmed again by searching through the W3C docs)

Fixes #929
Updates the `engines` section in the `package.json` to match the one from Angular.

Fixes #1502.
* chore: add autoprefixer to gulp

* At the time of moving to gulp, the autoprefixer is no longer running against the CSS.

* Re-introducing the autoprefixer for the "latest two versions" as in the README stated, does make sure that each properties are working within the supported browsers.

* Explicitly exclude IE 10 and lower browsers.
* fix(slide-toggle): remove view encapsulation

* Removes the ViewEncapsulation from the slide-toggle component to allow developer overwriting the styles easly.

Fixes #1343.

* Make _hasFocus variable public again for AOT compiler
* feat(md-snack-bar): Create initial MdSnackBar.

* Add enter and exit animation to MdSnackBar.

* feat(md-snack-bar): Create initial MdSnackBar.

* feat(md-snack-bar): Create initial MdSnackBar.

* Add enter and exit animation to MdSnackBar.
@dasois
Copy link
Contributor Author

dasois commented Nov 16, 2016

done

Stretch tabs grow until they fill the tab group. Demo app.

Closes #1353
@dasois
Copy link
Contributor Author

dasois commented Nov 16, 2016

updated demo app

<md-tab-group class="demo-tab-group" md-stretch-tabs>
<md-tab *ngFor="let tab of tabs; let i = index" [disabled]="i == 1">
<template md-tab-label>{{tab.label}}</template>
<template md-tab-content>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

md-tab-content no longer exists. Try rebasing and testing it out in the demo app

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Nov 17, 2016
@dasois dasois closed this Nov 17, 2016
@dasois dasois deleted the feat_fixed-tabs branch November 17, 2016 12:30
@dasois
Copy link
Contributor Author

dasois commented Nov 17, 2016

sorry, had some issues rebasing.
New pull-request is: #1909

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] Allow option to stretch tab labels across the header