Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/overlay): resolve regression when overlay is imported through shorthand path #22043

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix(cdk/overlay): resolve regression when overlay is imported through shorthand path #22043

merged 1 commit into from
Mar 2, 2021

Conversation

crisbeto
Copy link
Member

Fixes a regression caused by #21896 where importing the overlay styles through ~@angular/cdk/overlay would result in a compilation error.

@crisbeto
fix(cdk/overlay): resolve regression when overlay is imported through…
5513f6d 
… shorthand path

Fixes a regression caused by angular#21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround regression This issue is related to a regression target: patch This PR is targeted for the next patch release labels Feb 26, 2021
@crisbeto crisbeto requested a review from devversion as a code owner February 26, 2021 16:07
@crisbeto crisbeto requested a review from jelbourn as a code owner February 26, 2021 16:07
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2021
@wagnermaciel wagnermaciel self-requested a review March 1, 2021 16:59
wagnermaciel
wagnermaciel approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
jelbourn
jelbourn approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 2, 2021
@wagnermaciel wagnermaciel merged commit efc0f9e into angular:master Mar 2, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Mar 2, 2021
@crisbeto @wagnermaciel
fix(cdk/overlay): resolve regression when overlay is imported through…
f8cd27e 
… shorthand path (angular#22043)

Fixes a regression caused by angular#21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
@wagnermaciel wagnermaciel mentioned this pull request Mar 2, 2021
Merged
@wagnermaciel
Copy link
Contributor

@crisbeto This had merge conflicts with 11.2.x, so I changed it to target: minor and created #22086 to get it into 11.2.x since this seemed urgent.

wagnermaciel added a commit that referenced this pull request Mar 2, 2021
@wagnermaciel @crisbeto
fix(cdk/overlay): resolve regression when overlay is imported through…
2010bb5 
… shorthand path (#22043) (#22086)

Fixes a regression caused by #21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.

Co-authored-by: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
This was referenced Mar 6, 2021
Closed
Closed
Merged
Merged
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 25, 2021
@crisbeto
refactor(cdk/overlay): use index files for public Sass API instead of…
2fb0b25 
… copying files out

Currently we copy out a few of the CDK .scss files to the root of the `cdk` package so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see angular#22043).

These changes rename the files to `_index.scss` which will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths.
@crisbeto crisbeto mentioned this pull request Mar 25, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 29, 2021
@crisbeto
refactor(cdk/overlay): use index files for public Sass API instead of…
501b78d 
… copying files out

Currently we copy out a few of the CDK .scss files to the root of the `cdk` package so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see angular#22043).

These changes rename the files to `_index.scss` which will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths.

BREAKING CHANGES:
Deep imports to the following CDK .scss files need to be updated:
* `@import '~@angular/cdk/overlay/overlay'` -> `@import ~@angular/cdk/overlay`
* `@import '~@angular/cdk/a11y/a11y'` -> `@import ~@angular/cdk/a11y`
* `@import '~@angular/cdk/text-field/text-field'` -> `@import ~@angular/cdk/text-field`
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 29, 2021
@crisbeto
refactor(cdk/overlay): use index files for public Sass API instead of…
d042d62 
… copying files out

Currently we copy out a few of the CDK .scss files to the root of the `cdk` package so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see angular#22043).

These changes rename the files to `_index.scss` which will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths.

BREAKING CHANGES:
Deep imports to the following CDK .scss files need to be updated:
* `@import '~@angular/cdk/overlay/overlay'` -> `@import ~@angular/cdk/overlay`
* `@import '~@angular/cdk/a11y/a11y'` -> `@import ~@angular/cdk/a11y`
* `@import '~@angular/cdk/text-field/text-field'` -> `@import ~@angular/cdk/text-field`
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 30, 2021
@crisbeto
refactor(cdk/overlay): use index files for public Sass API instead of…
ee2558c 
… copying files out

Currently we copy out a few of the CDK .scss files to the root of the `cdk` package so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see angular#22043).

These changes rename the files to `_index.scss` which will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths.

BREAKING CHANGES:
Deep imports to the following CDK .scss files need to be updated:
* `@import '~@angular/cdk/overlay/overlay'` -> `@import ~@angular/cdk/overlay`
* `@import '~@angular/cdk/a11y/a11y'` -> `@import ~@angular/cdk/a11y`
* `@import '~@angular/cdk/text-field/text-field'` -> `@import ~@angular/cdk/text-field`
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 30, 2021
@crisbeto
refactor(cdk/overlay): use index files for public Sass API instead of…
eefa8e1 
… copying files out

Currently we copy out a few of the CDK .scss files to the root of the `cdk` package so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see angular#22043).

These changes rename the files to `_index.scss` which will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths.

BREAKING CHANGES:
Deep imports to the following CDK .scss files need to be updated:
* `@import '~@angular/cdk/overlay/overlay'` -> `@import ~@angular/cdk/overlay`
* `@import '~@angular/cdk/a11y/a11y'` -> `@import ~@angular/cdk/a11y`
* `@import '~@angular/cdk/text-field/text-field'` -> `@import ~@angular/cdk/text-field`
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround regression This issue is related to a regression target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @wagnermaciel @jelbourn