refactor(cdk/overlay): use index files for public Sass API instead of copying files out #22343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
crisbeto
added
P2
devversion
approved these changes
Mar 25, 2021
jelbourn
approved these changes
Mar 29, 2021
mmalerba
approved these changes
Mar 29, 2021
crisbeto
force-pushed
the
cdk-index-files
branch
from
2fb0b25 to
501b78d
Compare
|
Done. Also resolved the merge conflicts. |
crisbeto
force-pushed
the
cdk-index-files
branch
2 times, most recently
from
d042d62 to
ee2558c
Compare
… copying files out Currently we copy out a few of the CDK .scss files to the root of the `cdk` package so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see angular#22043). These changes rename the files to `_index.scss` which will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths. BREAKING CHANGES: Deep imports to the following CDK .scss files need to be updated: * `@import '~@angular/cdk/overlay/overlay'` -> `@import ~@angular/cdk/overlay` * `@import '~@angular/cdk/a11y/a11y'` -> `@import ~@angular/cdk/a11y` * `@import '~@angular/cdk/text-field/text-field'` -> `@import ~@angular/cdk/text-field`
crisbeto
force-pushed
the
cdk-index-files
branch
from
ee2558c to
eefa8e1
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we copy out a few of the CDK .scss files to the root of the
cdkpackage so that they're more convenient to consume. The problem with this is that it prevents us from importing other Sass files, because the import path will be wrong after the files are copied (see #22043).These changes rename the files to
_index.scsswhich will allow users to maintain the same import paths while allowing us to remove the file copying logic and not having to worry about import paths.Note: the commit message mentions
overlaydue to the linting rules, but this also applies toa11yandtext-field.BREAKING CHANGES:
Deep imports to the following CDK .scss files need to be updated:
@import '~@angular/cdk/overlay/overlay'->@import ~@angular/cdk/overlay@import '~@angular/cdk/a11y/a11y'->@import ~@angular/cdk/a11y@import '~@angular/cdk/text-field/text-field'->@import ~@angular/cdk/text-field