Skip to content

fix(cdk/testing): fix value stringification in harnesses #23421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmalerba merged 2 commits into from
Aug 31, 2021
Merged

fix(cdk/testing): fix value stringification in harnesses #23421

mmalerba merged 2 commits into from
Aug 31, 2021

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 20, 2021

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Aug 20, 2021
@mmalerba mmalerba requested a review from crisbeto August 20, 2021 21:55
@mmalerba mmalerba requested a review from devversion as a code owner August 20, 2021 21:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 20, 2021
@mmalerba mmalerba added the G This is is related to a Google internal issue label Aug 20, 2021
crisbeto
crisbeto reviewed Aug 21, 2021
View reviewed changes
mmalerba
mmalerba commented Aug 23, 2021
View reviewed changes
Copy link
Contributor Author

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, ptal

crisbeto
crisbeto approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2021
@mmalerba mmalerba merged commit 829e095 into angular:master Aug 31, 2021
mmalerba added a commit that referenced this pull request Aug 31, 2021
@mmalerba
fix(cdk/testing): fix value stringification in harnesses (#23421)
7177d33 
* fix(cdk/testing): fix value stringification in harnesses

* fixup! fix(cdk/testing): fix value stringification in harnesses

(cherry picked from commit 829e095)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 1, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @crisbeto @devversion