fix(material/datepicker): remove abbr from day of week header #24106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
force-pushed
the
datepicker-sunday-sunday-sunday
branch
from
8f631fe
to
7fd0b94
Compare
|
FYI I added the |
googlebot
added
the
cla: yes
|
Hmm.. I tested on ChromeOS, and this works. Let's compare this to what's on material.angular.io right now. Here's what each screenreader reads navigating from left to right along the day-of-week header. On material.angular.io:
With this change:
Voiceover and Chromevox are still reading the day-of-week twice because it's the header cell. It reads "Sunday" once for the name of the column, then again for the text content of the cell. IN other words, it announces the name of the column the same as for any other cell in the table (e.g. Voiceover reads"Sunday January 16 16 Column 1 of 7" ). I wasn't able to navigate to the day-of-week header on NVDA. |
|
Can you push up a preview build? I'll give it a spin in VO and ChromeVox |
zarend
force-pushed
the
datepicker-sunday-sunday-sunday
branch
from
7fd0b94
to
75cb058
Compare
zarend
added
Accessibility
|
Deployed dev-app to: https://ng-comp-dev--pr-24106-aaac56fa2f9d803d1c9e49a08ca0ad47-betozw7j.web.app |
|
Good idea, a deploy is ready for you to look at https://ng-comp-dev--pr-24106-75cb058b9fb5ebe218a0f8a3bb260a47-h91vbocv.web.app |
jelbourn
reviewed
Jan 21, 2022
zarend
commented
Jan 21, 2022
zarend
force-pushed
the
datepicker-sunday-sunday-sunday
branch
from
75cb058
to
3bfa3fe
Compare
Removes the `abbr` tag that is nested inside the cells of the day of the week header. This is to fix angular#23477 where VoiceOver reads day of week three times: 'Sunday, Sunday, Sunday...' I tested this change on VoiceOverAfter this change and sometimes it read the day of week twice and sometimes it read it once. When navigating from a day on the calendar to the header it reads: "row 1 of 7 Sunday S". When navigating from Sunday to Monday, it reads "Monday Monday M Column 2 of 7". Tested on macos 12.0.1 (21A559) with chrome Version 96.0.4664.110 (Official Build) (x86_64). I'll leave this as a draft until I can at least test it on other screenreaders. fixes angular#23477
zarend
force-pushed
the
datepicker-sunday-sunday-sunday
branch
from
3bfa3fe
to
aaac56f
Compare
zarend
added a commit
that referenced
this pull request
Feb 4, 2022
Removes the `abbr` tag that is nested inside the cells of the day of the week header. This is to fix #23477 where VoiceOver reads day of week three times: 'Sunday, Sunday, Sunday...' I tested this change on VoiceOverAfter this change and sometimes it read the day of week twice and sometimes it read it once. When navigating from a day on the calendar to the header it reads: "row 1 of 7 Sunday S". When navigating from Sunday to Monday, it reads "Monday Monday M Column 2 of 7". Tested on macos 12.0.1 (21A559) with chrome Version 96.0.4664.110 (Official Build) (x86_64). I'll leave this as a draft until I can at least test it on other screenreaders. fixes #23477 (cherry picked from commit 7a6549f)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Feb 15, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.1/13.2.2) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.1/13.2.2) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1322-enamel-eagle-2022-02-09) [Compare Source](angular/components@13.2.1...13.2.2) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [4b6e83274](angular/components@4b6e832) | fix | **scrolling:** fix scrolling in appendOnly mode ([#​24153](angular/components#24153)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [f5199eeeb](angular/components@f5199ee) | fix | **datepicker:** fix improper focus trapping with VoiceOver and ChromeVox ([#​24300](angular/components#24300)) | | [a72bcbe50](angular/components@a72bcbe) | fix | **datepicker:** remove abbr from day of week header ([#​24106](angular/components#24106)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [3bbcb444f](angular/components@3bbcb44) | fix | **mdc-checkbox:** add missing classes for checked ([#​24350](angular/components#24350)) | ##### material-experiental | Commit | Type | Description | | -- | -- | -- | | [70bec6054](angular/components@70bec60) | fix | **mdc-list:** update material-components-web to pick up multi-select list keyboard support ([#​24354](angular/components#24354)) | #### Special Thanks Alan Agius, Artur Androsovych, Chabbey François, Joey Perrott, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner, Zach Arend and renovate\[bot] <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1161 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…r#24106) Removes the `abbr` tag that is nested inside the cells of the day of the week header. This is to fix angular#23477 where VoiceOver reads day of week three times: 'Sunday, Sunday, Sunday...' I tested this change on VoiceOverAfter this change and sometimes it read the day of week twice and sometimes it read it once. When navigating from a day on the calendar to the header it reads: "row 1 of 7 Sunday S". When navigating from Sunday to Monday, it reads "Monday Monday M Column 2 of 7". Tested on macos 12.0.1 (21A559) with chrome Version 96.0.4664.110 (Official Build) (x86_64). I'll leave this as a draft until I can at least test it on other screenreaders. fixes angular#23477
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
abbrtag that is nested inside the cells of the day of theweek header. This is to fix #23477 where VoiceOver reads day of week
three times: 'Sunday, Sunday, Sunday...'
I tested this change on VoiceOverAfter this change and sometimes it read
the day of week twice and sometimes it read it once. When navigating
from a day on the calendar to the header it reads: "row 1 of 7 Sunday
S". When navigating from Sunday to Monday, it reads "Monday Monday M
Column 2 of 7".
Tested on macos 12.0.1 (21A559) with chrome Version 96.0.4664.110 (Official Build) (x86_64).
I'll leave this as a draft until I can at least test it on other
screenreaders.
fixes #23477