fix(multiple): touch targets not excluded in densities lower than -2 #25108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that touch targets were being removed only on `-2` or `minimum` densities, but not anything lower. Also moves the check into a common mixin so we only have one place where it needs to be changed.
crisbeto
added
P3
mmalerba
approved these changes
Jun 19, 2022
This was referenced Jul 1, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jul 4, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.3/14.0.4) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.3/14.0.4) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1404-sapphire-sandal-2022-06-29) [Compare Source](angular/components@14.0.3...14.0.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [c970ff9d3](angular/components@c970ff9) | fix | **stepper:** isErrorState accepts AbstractControl instead of UntypedFormControl to avoid compiler errors when strict typing is enabled ([#​25105](angular/components#25105)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [1b50a0743](angular/components@1b50a07) | fix | **mdc-chips:** missing role for trailing actions container ([#​25160](angular/components#25160)) | ##### docs | Commit | Type | Description | | -- | -- | -- | | [c4ae88fb5](angular/components@c4ae88f) | fix | rename master to something else ([#​25151](angular/components#25151)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [301f6b0ef](angular/components@301f6b0) | fix | touch targets not excluded in densities lower than -2 ([#​25108](angular/components#25108)) | #### Special Thanks Ammar Najjar, Amy Sorto, Angular Robot, James Jansson, Kristiyan Kostadinov, Paul Gschwendtner, Zach Arend and renovate\[bot] <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1441 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that touch targets were being removed only on
-2orminimumdensities, but not anything lower.Also moves the check into a common mixin so we only have one place where it needs to be changed.