Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-chips): missing role for trailing actions container #25160

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

crisbeto
Copy link
Member

Fixes that we didn't have a role="gridcell" around the trailing action of a mat-chip-row.

…ns container

Fixes that we didn't have a `role="gridcell"` around the trailing action of a `mat-chip-row`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jun 25, 2022
@crisbeto crisbeto requested a review from mmalerba as a code owner June 25, 2022 07:42
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2022
@crisbeto crisbeto self-assigned this Jun 27, 2022
@crisbeto crisbeto merged commit 8cf2e99 into angular:main Jun 27, 2022
crisbeto added a commit that referenced this pull request Jun 27, 2022
…ns container (#25160)

Fixes that we didn't have a `role="gridcell"` around the trailing action of a `mat-chip-row`.

(cherry picked from commit 8cf2e99)
crisbeto added a commit that referenced this pull request Jun 27, 2022
…ns container (#25160)

Fixes that we didn't have a `role="gridcell"` around the trailing action of a `mat-chip-row`.

(cherry picked from commit 8cf2e99)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 4, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.3/14.0.4) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.3/14.0.4) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1404-sapphire-sandal-2022-06-29)

[Compare Source](angular/components@14.0.3...14.0.4)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [c970ff9d3](angular/components@c970ff9) | fix | **stepper:** isErrorState accepts AbstractControl instead of UntypedFormControl to avoid compiler errors when strict typing is enabled ([#&#8203;25105](angular/components#25105)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [1b50a0743](angular/components@1b50a07) | fix | **mdc-chips:** missing role for trailing actions container ([#&#8203;25160](angular/components#25160)) |

##### docs

| Commit | Type | Description |
| -- | -- | -- |
| [c4ae88fb5](angular/components@c4ae88f) | fix | rename master to something else ([#&#8203;25151](angular/components#25151)) |

##### multiple

| Commit | Type | Description |
| -- | -- | -- |
| [301f6b0ef](angular/components@301f6b0) | fix | touch targets not excluded in densities lower than -2 ([#&#8203;25108](angular/components#25108)) |

#### Special Thanks

Ammar Najjar, Amy Sorto, Angular Robot, James Jansson, Kristiyan Kostadinov, Paul Gschwendtner, Zach Arend and renovate\[bot]

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1441
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants