chore(e2e): update to latest protractor version #2608
Conversation
googlebot
added
the
cla: yes
devversion
force-pushed
the
chore/protractor-chord-fix
branch
from
8c937a4
to
47842a5
Compare
* Updates to the latest Protractor version, which now uses Selenium V3 * The new types for Protractor v5 include the fix for the missing `chord` function (See DefinitelyTyped/DefinitelyTyped@123690b) * Methods like `innerHtml` have been removed in Protractor v5 (https://github.com/angular/protractor/blob/master/CHANGELOG.md)
devversion
force-pushed
the
chore/protractor-chord-fix
branch
from
245e4d8
to
4d734a6
Compare
| @@ -33,3 +33,4 @@ | |||
| npm-debug.log | |||
| testem.log | |||
| /.chrome | |||
| yarn.lock | |||
There was a problem hiding this comment.
I thought that the yarn.lock was was supposed to be checked into source control?
https://yarnpkg.com/en/docs/yarn-lock#toc-check-into-source-control
There was a problem hiding this comment.
It is - (depends on the project) and then I would need to commit it to the Material 2 repository?
There was a problem hiding this comment.
Okay, let's handle that in another PR when we also lock some more dependencies.
|
@jelbourn Saucelabs was using a super-old chromedriver version, which didn't work properly with Chrome v55. Specified the latest version and everything passes now. |
jelbourn
added
pr: lgtm
action: merge
* chore(e2e): update to latest protractor version * Updates to the latest Protractor version, which now uses Selenium V3 * The new types for Protractor v5 include the fix for the missing `chord` function (See DefinitelyTyped/DefinitelyTyped@123690b) * Methods like `innerHtml` have been removed in Protractor v5 (https://github.com/angular/protractor/blob/master/CHANGELOG.md) * Test later chromedriver version
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates to the latest Protractor version, which now uses Selenium V3
The new types for Protractor v5 include the fix for the missing
chordfunction(See DefinitelyTyped/DefinitelyTyped@123690b)
Methods like
innerHtmlhave been removed in Protractor v5 (https://github.com/angular/protractor/blob/master/CHANGELOG.md)Due to an Protractor issue I just noticed that we don't run the latest Chrome version for e2e tests.
Closes #2384