This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix: no longer use es6 let statement #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently in Protractor v5 the Angular detection script uses ES6 features like the `let` modifier. This can break Protractor on browsers, which doesn't support those statements. > See https://saucelabs.com/beta/tests/275f75091dac40a0a3374d29d912caee/commands#11
cnishina
approved these changes
Jan 12, 2017
|
@devversion do you have any estimates when new protractor version with this fix will be released? |
|
The plan is Monday or early next week. |
RomanHotsiy
added a commit
to Redocly/redoc
that referenced
this pull request
Jan 28, 2017
Until angular/protractor#3963 is merged This reverts commit 117d5bf.
jsmartfo
pushed a commit
to americanexpress/ReDoc
that referenced
this pull request
Feb 1, 2017
Until angular/protractor#3963 is merged This reverts commit 117d5bf.
igniteram
pushed a commit
to igniteram/protractor
that referenced
this pull request
Feb 21, 2017
* Currently in Protractor v5 the Angular detection script uses ES6 features like the `let` modifier. This can break Protractor on browsers, which doesn't support those statements. > See https://saucelabs.com/beta/tests/275f75091dac40a0a3374d29d912caee/commands#11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
letmodifier.This can break Protractor on browsers, which doesn't support those statements.
Note: This currently makes Protractor v5 hard to use on older browsers. (On Material 2 we will update browsers)
cc. @sjelin @cnishina