Skip to content

Button token fixes #28373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisbeto merged 2 commits into from
Jan 8, 2024
Merged

Button token fixes #28373

crisbeto merged 2 commits into from
Jan 8, 2024

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 5, 2024 •
edited
Loading

  • Moves the base tokens of the button to the theme, rather than the structural styles. This is necessary for M3.
  • Emits the non-palette button tokens at the root of the theme.

@crisbeto
refactor(material/button): move base tokens to the theme
2a96cd5 
Moves the base tokens of the button to the theme, rather than the structural styles. This is necessary for M3.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 5, 2024
@crisbeto crisbeto requested a review from andrewseguin as a code owner January 5, 2024 05:52
@crisbeto crisbeto mentioned this pull request Jan 5, 2024
Closed
@crisbeto crisbeto added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Jan 5, 2024
@crisbeto crisbeto changed the title refactor(material/button): move base tokens to the theme Button token fixes Jan 5, 2024
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 5, 2024
@crisbeto
feat(material-experimental/theming): add M3 button tokens
6863412 
Sets up the tokens for the M3 buttons.

**Note:** the button shape doesn't show up at the moment. It'll be fixed once angular#28373 lands.
@crisbeto crisbeto mentioned this pull request Jan 5, 2024
Merged
@crisbeto crisbeto requested a review from devversion as a code owner January 5, 2024 09:42
@crisbeto
refactor(material/button): emit button tokens at the root
10ab7dd 
Reworks the button theme to emit the non-palette tokens at the root.
@devversion devversion removed their request for review January 5, 2024 16:19
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2024
@crisbeto crisbeto self-assigned this Jan 8, 2024
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 8, 2024
@crisbeto crisbeto merged commit b06cf5a into angular:main Jan 8, 2024
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 8, 2024
@crisbeto
feat(material-experimental/theming): add M3 button tokens
5fd5e4c 
Sets up the tokens for the M3 buttons.

**Note:** the button shape doesn't show up at the moment. It'll be fixed once angular#28373 lands.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 8, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker merge: preserve commits When the PR is merged, a rebase and merge should be performed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @andrewseguin