fix(material/select): adds cdkFocusTrap to attempt to make options focusable #29649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
crisbeto and
mmalerba
and removed request for
a team
|
A long time ago in #6856 we switched away from having focus on the options because it was problematic for VoiceOver on Safari. |
crisbeto
added
the
dev-app preview
|
Deployed dev-app for 9b1fe05 to: https://ng-dev-previews-comp--pr-angular-components-29649-dev-jesz4k9p.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
make-select-options-accessible-on-mobile
branch
from
84af25e
to
310bd74
Compare
…cuable Attempts to fix bug in Angular Components Select Component where the options in the listbox are not accessible/focusable on mobile. When swiping right to access the listbox the focus moves to the next focusable item rather than into the listbox of options. This fix adds cdkFocusTrap and cdkFocusAutoCapture to attempt to remedy that. Fixes b/285945157
…iveDescendant Updates previous fix to account for previous fix angular#6856 which refactored focus on listbox to use aria-activedescendant instead to manage focus. Fixes b/285945157
Updates previous fix to add useActiveDescendant=true to listbox in order to attempt to shift focus without using cdkFocusTrap. Fixes b/285945157
essjay05
force-pushed
the
make-select-options-accessible-on-mobile
branch
from
310bd74
to
9b1fe05
Compare
|
Closing this PR as this looks to be a bug outside of Angular Components' scope. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix bug in Angular Components Select Component where the options in the listbox are not accessible/focusable on mobile. When swiping right to access the listbox the focus moves to the next focusable item rather than into the listbox of options. This fix adds cdkFocusTrap and cdkFocusAutoCapture to attempt to remedy that.
Fixes b/285945157