Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/select): adds cdkFocusTrap to attempt to make options focusable #29649

Closed
wants to merge 3 commits into from
Closed

fix(material/select): adds cdkFocusTrap to attempt to make options focusable #29649

wants to merge 3 commits into from

Commits on Aug 29, 2024

  1. fix(material/select): adds cdkFocusTrap to attempt to make options fo… 

    …cuable

Attempts to fix bug in Angular Components Select Component where the options
in the listbox are not accessible/focusable on mobile. When swiping right to
access the listbox the focus moves to the next focusable item rather than
into the listbox of options. This fix adds cdkFocusTrap and cdkFocusAutoCapture
to attempt to remedy that.

Fixes b/285945157
    @essjay05
    essjay05 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    34ff3f1 View commit details
    Browse the repository at this point in the history

  2. refactor(material/select): replace cdkFocusTrap with cdkListboxUseAct… 

    …iveDescendant

Updates previous fix to account for previous fix angular#6856 which refactored
focus on listbox to use aria-activedescendant instead to manage focus.

Fixes b/285945157
    @essjay05
    essjay05 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1f9ef0c View commit details
    Browse the repository at this point in the history

  3. refactor(material/select): add useActiveDescendant attribute 

    Updates previous fix to add useActiveDescendant=true to
listbox in order to attempt to shift focus without using
cdkFocusTrap.

Fixes b/285945157
    @essjay05
    essjay05 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9b1fe05 View commit details
    Browse the repository at this point in the history