-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): add support for more input attributes #343
feat(input): add support for more input attributes #343
Conversation
- Includes update to newest router - Completely rewrites checkbox tests
@jelbourn: I'm fine with this. It also becomes a good benchmark of how much bindings are a bottleneck. I needed to do this anyway for data-table. |
@matthewdenobrega can you rebase this PR on master? |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
I've rebased on master and updated the specs so they are more inline with the other specs for input. I'm not sure what the CLA warning is - I've signed the CLA and no-one else has contributed commits. |
@matthewdenobrega looks like your rebase didn't go very smoothly- 124 changed files. |
@jelbourn I don't rebase often so maybe I'm missing something, but the only differences between master and my branch are my changes:(master...matthewdenobrega:input-attributes) If something went wrong with the rebase I can branch off master again and redo the changes. |
@matthewdenobrega Not sure where it went awry, but the PR has 25 commits in it now (most of which are already in master). It might be easier to create a clean branch from |
New PR opened: #447 |
Closed in favor of #447 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Notes