Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): add mdTooltipClass #4893

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

willshowell
Copy link
Contributor

@willshowell willshowell commented May 31, 2017

Fixes #4601

  • I wasn't able to identify a reason for ViewEncapsulation to be on for the tooltip, so I set it to none. Will gladly revert if this is incorrect, but it will help users with their css customizations.
  • I chose to support the ngClass syntax to match select's panelClass. But if the user uses the key/value format and adds or removes a class that affects tooltip size while it's showing, its position won't update.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 31, 2017
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 14, 2017
@kara kara merged commit 734eccc into angular:master Jun 15, 2017
@willshowell willshowell deleted the feat/tooltip-class branch June 15, 2017 12:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add mdTooltipClass to allow CSS customization of tooltips
5 participants