Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(portal): detect changes for portal hostview while before attaching. (#4370)" #5131

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Jun 14, 2017

This reverts a change where attachComponentPortal in DomPortalHost would run detectChanges before attaching the embedded view to the view container.

This revert came about because it broke some datepicker features, but ultimately brought to light that having a call to detectChanges here prevents the user from initializing anything on the portal component before change detection runs, which means that any kind of one-time initialization will no longer work.

This also:

Fixes #5065

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 14, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment Jun 14, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 14, 2017
@kara kara merged commit 99fc668 into angular:master Jun 15, 2017
@jelbourn jelbourn deleted the snackbar-animation-rev-fix branch March 13, 2018 17:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker min attribute - dates before min dates are still available. Validation works
3 participants