Revert "fix(portal): detect changes for portal hostview while before attaching. (#4370)" #5131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a change where
attachComponentPortal
inDomPortalHost
would rundetectChanges
before attaching the embedded view to the view container.This revert came about because it broke some datepicker features, but ultimately brought to light that having a call to
detectChanges
here prevents the user from initializing anything on the portal component before change detection runs, which means that any kind of one-time initialization will no longer work.This also:
Fixes #5065