chore(snack-bar): rename MdSnackBarRef instance to componentInstance
#6566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instance is renamed to componentInstance to be consistent with other dialogs Closes angular#6252
This reverts commit 9e38ca9.
instance is renamed to componentInstance to be consistent with other dialogs Closes angular#6252
shaunak1111
requested review from
crisbeto,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
jelbourn
changed the title
instance to componentInstance
jelbourn
reviewed
Aug 21, 2017
src/lib/snack-bar/snack-bar-ref.ts
Outdated
| @@ -15,8 +15,8 @@ import {MdSnackBarContainer} from './snack-bar-container'; | |||
| * Reference to a snack bar dispatched from the snack bar service. | |||
| */ | |||
| export class MdSnackBarRef<T> { | |||
| /** The instance of the component making up the content of the snack bar. */ | |||
| instance: T; | |||
| /** The instance of snack bar. */ | |||
…ackBarRef_componentInstance_change
instance is renamed to componentInstance to be consistent with other dialogs Closes angular#6252
|
@shaunak1111 can you squash this into one commit with a breaking change message? |
…ackBarRef_componentInstance_change # Conflicts: # src/lib/snack-bar/snack-bar.spec.ts
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn Please review the PR