Skip to content

chore(snack-bar): rename MdSnackBarRef instance to componentInstance #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shaunak1111
Copy link

BREAKING CHANGE: Renamed variable instance to componentInstance to be consistent with other dialogs

Closes #6252

BREAKING CHANGE: Renamed variable instance to componentInstance to be consistent with other dialogs

Closes angular#6252
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 19, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 19, 2017
@kara kara added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Oct 4, 2017
@kara
Copy link
Contributor

kara commented Oct 4, 2017

Note: internal updates required

@josephperrott
Copy link
Member

Since this didn't make it in before RC, we will need to mark instance as deprecated have it still available to be used as a reference for the time being.

You should be able to just have a getter so the value is available:

/**
 * @docs-private
 * @deprecated
 */
get instance() { return this.componentInstance; }

@josephperrott josephperrott removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note pr: lgtm action: merge The PR is ready for merge by the caretaker presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Nov 6, 2017
@jelbourn
Copy link
Member

jelbourn commented Jan 9, 2018

Closing this since, after releasing 5.0.0, we aren't making any more breaking API changes.

@jelbourn jelbourn closed this Jan 9, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SnackBarRef component instance ?
5 participants