Update MergeConfig to be PullRequestConfig #237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the full config object Rather than merging the GithubConfig and MergeConfig objects together to be passed, we just pass the actual config object which contains both of these interfaces as attributes.
… attribute at pullRequest instead of merge Rather than using MergeConfig from merge in the ng-dev config object, we use PullRequestConfig from pullRequest as this config applies to all `pr` commands. Fixes angular#203 BREAKING CHANGE: `MergeConfig` has been renamed to `PullRequestConfig` and is now accessed via `pullRequest` on the provided ng-dev config.
josephperrott
added
action: merge
devversion
approved these changes
Sep 20, 2021
josephperrott
removed
the
action: review
…ver the attribute at pullRequest instead of merge
josephperrott
force-pushed
the
refactor-pr
branch
from
8511438 to
0dd6794
Compare
|
This PR was merged into the repository by commit 36d587a. |
josephperrott
added a commit
that referenced
this pull request
Sep 20, 2021
… attribute at pullRequest instead of merge (#237) Rather than using MergeConfig from merge in the ng-dev config object, we use PullRequestConfig from pullRequest as this config applies to all `pr` commands. Fixes #203 BREAKING CHANGE: `MergeConfig` has been renamed to `PullRequestConfig` and is now accessed via `pullRequest` on the provided ng-dev config. PR Close #237
josephperrott
added a commit
that referenced
this pull request
Sep 20, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.