Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update jasmine to ~4.0 #463

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 10, 2022

Update jasmine to ~4.0 as otherwise sharded tests never fail.

➜  dev-infra git:(breaking-changes-logs) ✗ yarn bazel test //ng-dev/release/publish/test:test
INFO: Analyzed target //ng-dev/release/publish/test:test (327 packages loaded, 9590 targets configured).
INFO: Found 1 test target...
Target //ng-dev/release/publish/test:test up-to-date:
  dist/bin/ng-dev/release/publish/test/test.sh
  dist/bin/ng-dev/release/publish/test/test_loader.js
  dist/bin/ng-dev/release/publish/test/test_require_patch.js
INFO: Elapsed time: 6.978s, Critical Path: 0.04s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//ng-dev/release/publish/test:test                              (cached) PASSED in 5.6s
  Stats over 6 runs: max = 5.6s, min = 2.5s, avg = 4.5s, dev = 1.4s

Executed 0 out of 1 test: 1 test passes.
INFO: Build completed successfully, 1 total action
➜  dev-infra git:(breaking-changes-logs) ✗ yarn add jasmine@~4.0.0 --dev
➤ YN0000: Done with warnings in 2s 87ms

➜  dev-infra git:(breaking-changes-logs) ✗ yarn bazel test //ng-dev/release/publish/test:test
INFO: Analyzed target //ng-dev/release/publish/test:test (349 packages loaded, 9911 targets configured).
INFO: Found 1 test target...
FAIL: //ng-dev/release/publish/test:test (shard 4 of 6) (see /private/var/tmp/_bazel_alanagius/c1aa91bd594ada81591526950a169e56/execroot/dev-infra/bazel-out/darwin-fastbuild/testlogs/ng-dev/release/publish/test/test/shard_4_of_6/test.log)

Update jasmine to ~4.0 as otherwise sharded tests never fail.

```
yarn bazel test //ng-dev/release/publish/test:test
INFO: Analyzed target //ng-dev/release/publish/test:test (327 packages loaded, 9590 targets configured).
INFO: Found 1 test target...
Target //ng-dev/release/publish/test:test up-to-date:
  dist/bin/ng-dev/release/publish/test/test.sh
  dist/bin/ng-dev/release/publish/test/test_loader.js
  dist/bin/ng-dev/release/publish/test/test_require_patch.js
INFO: Elapsed time: 6.978s, Critical Path: 0.04s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//ng-dev/release/publish/test:test                              (cached) PASSED in 5.6s
  Stats over 6 runs: max = 5.6s, min = 2.5s, avg = 4.5s, dev = 1.4s

Executed 0 out of 1 test: 1 test passes.
INFO: Build completed successfully, 1 total action
➜  dev-infra git:(breaking-changes-logs) ✗ yarn add jasmine@~4.0.0 --dev
➤ YN0000: Done with warnings in 2s 87ms

➜  dev-infra git:(breaking-changes-logs) ✗ yarn bazel test //ng-dev/release/publish/test:test
INFO: Analyzed target //ng-dev/release/publish/test:test (349 packages loaded, 9911 targets configured).
INFO: Found 1 test target...
FAIL: //ng-dev/release/publish/test:test (shard 4 of 6) (see /private/var/tmp/_bazel_alanagius/c1aa91bd594ada81591526950a169e56/execroot/dev-infra/bazel-out/darwin-fastbuild/testlogs/ng-dev/release/publish/test/test/shard_4_of_6/test.log)
```
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this pull request Mar 10, 2022
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this pull request Mar 10, 2022
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker dependencies Pull requests that update a dependency file labels Mar 10, 2022
@alan-agius4 alan-agius4 requested a review from devversion March 10, 2022 09:07
@devversion devversion merged commit f96f2e9 into angular:main Mar 10, 2022
@alan-agius4 alan-agius4 deleted the sharded-fails branch March 10, 2022 10:10
alexeagle pushed a commit to bazel-contrib/rules_nodejs that referenced this pull request Mar 11, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker comp: build dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants