Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@angular-devkit/build-optimizer): don't optimizer service-worker #77

Merged
merged 1 commit into from
Aug 5, 2017
Merged

fix(@angular-devkit/build-optimizer): don't optimizer service-worker #77

merged 1 commit into from
Aug 5, 2017

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Aug 5, 2017

@hansl
Copy link
Contributor

hansl commented Aug 5, 2017

Wouldn't it be better to work with a whitelist rather than a blacklist here? There will be more packages added to @angular in the future and we might want to opt them in rather than out (so current versions are future proof).

@filipesilva
Copy link
Contributor Author

@hansl added whitelist and check to make sure it only optimizes .es5.js files (see #78).

@hansl hansl merged commit 110bea7 into angular:master Aug 5, 2017
@zackarychapple
Copy link

Is there a targeted version of the CLI that this will be landing in?

@filipesilva filipesilva deleted the blacklist-service-worker branch August 7, 2017 13:11
@filipesilva
Copy link
Contributor Author

Next 1.3.x release.

@zackarychapple
Copy link

Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants