This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(select): add mdOnClose expression eval event
closes #3217
- Loading branch information
1 parent
67be5ce
commit d7bfc86
Showing
2 changed files
with
21 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit d7bfc86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Ryan!
Thanks for the quick fix! I hate to nitpick but I had a question about the "expression=" bit of it.
With an = it does not run async correct? So this would no play nicely with promises?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DerekLouie it should work with promises. The expression=
is just jsdoc notation
I am a little fuzzy on this, but I must ask is this async? If not could we make this 'expression&' instead?
We would like to pass a promise into this in the persisting data case and we would like the dropdown wait for the promise to resolve before further actions are taken.