Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

adding fullscreen option for mobile to $mdDialog #2148

Closed
dohomi opened this issue Apr 3, 2015 · 21 comments
Closed

adding fullscreen option for mobile to $mdDialog #2148

dohomi opened this issue Apr 3, 2015 · 21 comments
Assignees
Labels
for: internal contributor The team will address this issue and community PRs are not requested. pr: merge ready This PR is ready for a caretaker to review type: enhancement
Milestone

Comments

@dohomi
Copy link

dohomi commented Apr 3, 2015

Hello,
I would like to know if you plan to include a fullscreen option to $mdDialog with some more responsive functionalities? Would be very great for using dialogs on mobile devices:

screen shot 2015-04-03 at 8 37 49 am

http://www.google.com/design/spec/components/dialogs.html#dialogs-full-screen-dialogs

Thanks for your great work!

@ThomasBurleson ThomasBurleson added type: enhancement for: internal contributor The team will address this issue and community PRs are not requested. labels Apr 3, 2015
@ThomasBurleson ThomasBurleson added this to the 0.10.0 milestone Apr 3, 2015
@anderson-arlen
Copy link
Contributor

+1

@ThomasBurleson ThomasBurleson modified the milestones: 0.10.0, 0.11.0 Jun 16, 2015
@TBxy
Copy link

TBxy commented Jun 25, 2015

+1

2 similar comments
@stunaz
Copy link

stunaz commented Jun 25, 2015

+1

@kevindstanley1988
Copy link

+1

@rschmukler
Copy link
Contributor

I am wondering if this is more of a request for a router-like functionality that happens to animate like a full-screen dialog... ie. thinking in-terms of ui-router-like states I see that dialog as being something like:

$stateProvider.state('calendar.new-event', function() {
  return {
    templateUrl: '/my-full-screen-dialog/template.html',
    controller: 'MyFullScreenCtrl',
    animate: 'full-screen-dialog'
  }
});

My point being, is this something that we really want to shoe-horn into the $mdDialog service, or is it really more of a feature to be handled by some sort of router

@dohomi
Copy link
Author

dohomi commented Jun 29, 2015

Very helpful would be a variable to inject into the controller on which media breakpoint the dialog should be displayed fullscreen:

$mdDialog.show({
  controller:'MyController',
  controllerAs:'vm',
  mdIsFullscreen: 'sm,md' 
});

// or maybe even better inside of html directive:

<md-dialog md-is-fullscreen="$mdMedia('max-width:800px')">

This would cover almost every use case and I'd rather like to see this feature inside of the $mdDialog than outside of the component. For a hybrid app most of the dialogs working well with the default handling, but lets say for 'sm' and 'md' on a more complex dialog I'd like to show it fullscreen. It would be great to support similar handling like the md-is-locked-open="$mdMedia('min-width: 333px')" of the mdSidenavcomponent.

@kevindstanley1988
Copy link

+1 @dohomi fantastic thoughts. I would love to see that implemented exactly as you have described!

@anderson-arlen
Copy link
Contributor

Modifying a dialog to be full screen just takes a couple lines of CSS: see CodePen. While a standardized class for this would be nice, I think we should instead focus our energy on opening multiple dialogs as that is the core functionality we are missing here. See #698.

@ThomasBurleson ThomasBurleson modified the milestones: 0.11.0, post-1.0 Jul 31, 2015
@ianchenguo
Copy link

+1

3 similar comments
@adamwmeek
Copy link

+1

@guiporto
Copy link

+1

@subins
Copy link

subins commented Aug 20, 2015

+1

@bradmartin
Copy link

Since @anderson-arlen codepen isn't available.

Use the following css class on md-dialog and it should be full screen and working fine. You might want to wrap this in a media query depending on your needs like so.

/* $mdDialog - fullscreen dialog styling */
@media screen and (max-width: 760px){

       .fullscreen-dialog {
       height:100%;
       width:100%;
       max-height:100%;
       max-width: 100%;
       position: absolute;
       top: 0;
       left: 0;
       border-radius: 0;
   }
}

This is working fine for my mobile app without any issues.

@rafaelgondim
Copy link

+1

@ThomasBurleson ThomasBurleson self-assigned this Aug 29, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.12.0, post-1.0 Aug 29, 2015
@galenbrazell
Copy link

+1

@jamalx31
Copy link

+1

@lukmadev
Copy link

+1

@bradmartin Very nice. :)

@ThomasBurleson ThomasBurleson modified the milestones: 0.12, 0.13 Oct 15, 2015
@plaramee1
Copy link

+1, It's a must for mobile devices !

@ghost
Copy link

ghost commented Oct 28, 2015

+1

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3, 1.0-rc4 Oct 30, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
EladBezalel added a commit that referenced this issue Nov 17, 2015
Added `smFullscreen` option that if it's set to true `.md-dialog-fullscreen` class is added to `<md-dialog>` that
maximizing the dialog to the whole screen.

fixes #2148
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Nov 17, 2015
EladBezalel added a commit that referenced this issue Nov 23, 2015
Added `smFullscreen` option that if it's set to true `.md-dialog-fullscreen` class is added to `<md-dialog>` that
maximizing the dialog to the whole screen.

fixes #2148
EladBezalel added a commit that referenced this issue Nov 23, 2015
Added `smFullscreen` option that if it's set to true `.md-dialog-fullscreen` class is added to `<md-dialog>` that
maximizing the dialog to the whole screen.

fixes #2148
EladBezalel added a commit that referenced this issue Nov 24, 2015
Added `fullscreen` option that if it's set to true `.md-dialog-fullscreen` class is added to `<md-dialog>` that
maximizing the dialog to the whole screen.

fixes #2148
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
for: internal contributor The team will address this issue and community PRs are not requested. pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.