Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(dialog): added fullscreen option to dialog #5793

Closed
wants to merge 1 commit into from

Conversation

EladBezalel
Copy link
Member

Added fullscreen option that if it's set to true .md-dialog-fullscreen class is added to <md-dialog> that maximizing the dialog to the whole screen.

fixes #2148

@EladBezalel EladBezalel added the needs: review This PR is waiting on review from the team label Nov 17, 2015
@EladBezalel EladBezalel force-pushed the feat/dialog-sm-fullscreen branch 2 times, most recently from 385c55d to 95aeadd Compare November 23, 2015 19:07
@ThomasBurleson
Copy link
Contributor

I will change this to be consistent with Layouts and md- attributes: md-fullscreen-sm

@EladBezalel
Copy link
Member Author

fullscreen is only dialog feature, are you sure it should be in layouts?

@ThomasBurleson
Copy link
Contributor

I am sure: if you are using a breakpoint syntax then we must be consistent.

@EladBezalel
Copy link
Member Author

how are you going to implement it?
md-fullscreen-sm is too specific.

@ThomasBurleson ThomasBurleson modified the milestone: 1.0-rc5 Nov 24, 2015
Added `fullscreen` option that if it's set to true `.md-dialog-fullscreen` class is added to `<md-dialog>` that
maximizing the dialog to the whole screen.

fixes #2148
@EladBezalel EladBezalel changed the title feat(dialog): added fullscreen option to small screens feat(dialog): added fullscreen option to dialog Nov 24, 2015
@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Nov 24, 2015
@EladBezalel EladBezalel deleted the feat/dialog-sm-fullscreen branch November 25, 2015 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding fullscreen option for mobile to $mdDialog
2 participants