Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Ripple effect animation inconsistent with polymer #3952

Closed
austincondiff opened this issue Jul 30, 2015 · 1 comment
Closed

Ripple effect animation inconsistent with polymer #3952

austincondiff opened this issue Jul 30, 2015 · 1 comment
Assignees
@robertmesserle
Labels
type: performance This issue is related to performance ui: ink
Milestone
0.11.0

Comments

@austincondiff
Copy link

The ripple effect seems a little off when compared to polymer and buttons found across other google sites and apps. It feels a little slow and it doesn't look like the ink starts out at full opacity and fades out as seen in polymer. The button shadow appears a little off as well especially on the active state.

Compare the buttons here:
https://material.angularjs.org/latest/#/demo/material.components.button

to the button found on this page:
https://play.google.com/music/listen#/sulp

and in Polymer:
https://elements.polymer-project.org/elements/paper-button?active=paper-button&view=demo:demo/index.html

This fix would help the ripple to be a little more visible when used in situations where the button parent animates off the screen for example.
@ThomasBurleson ThomasBurleson added ui: ink type: performance This issue is related to performance severity: performance This issue causes a significant performance degradation and removed severity: performance This issue causes a significant performance degradation labels Jul 30, 2015
@ThomasBurleson ThomasBurleson added this to the 0.11.0 milestone Jul 30, 2015
@ThomasBurleson
Copy link
Contributor

@robertmesserle - This is serendipitous since your are re-architecting Ripple...

This was referenced Aug 10, 2015
Closed
Closed
Closed
@naomiblack naomiblack modified the milestones: 0.12.0, 0.11.0 Aug 14, 2015
robertmesserle pushed a commit that referenced this issue Aug 17, 2015
refactor(ripple): rewrite of the ripple service using manual animatio…
e92dd26 
…n and providing more control over the ripples states

Closes #4166

Closes #4199
Closes #3952
Closes #3346
Closes #2905
Closes #2636
Closes #2149
Closes #1597
Closes #1595
Closes #1398
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@kennethcachia
refactor(ripple): rewrite of the ripple service using manual animatio…
4a57f4c 
…n and providing more control over the ripples states

Closes angular#4166

Closes angular#4199
Closes angular#3952
Closes angular#3346
Closes angular#2905
Closes angular#2636
Closes angular#2149
Closes angular#1597
Closes angular#1595
Closes angular#1398
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@robertmesserle robertmesserle

Labels
type: performance This issue is related to performance ui: ink
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
4 participants
@ThomasBurleson @robertmesserle @austincondiff @naomiblack