This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Ripple rewrite #4166
Closed
Ripple rewrite #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
2 times, most recently
from
90af151 to
3c4eeac
Compare
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
3 times, most recently
from
2756f28 to
8c439b7
Compare
| * Controller used by the ripple service in order to apply ripples | ||
| * @ngInject | ||
| */ | ||
| function InkRippleServiceController ($scope, $element, rippleOptions, $window, $timeout, $mdUtil) { |
There was a problem hiding this comment.
I would just call this InkRippleCtrl
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
from
8c439b7 to
e0ed23b
Compare
| if (this.ripples.length === 0) this.container.css({ backgroundColor: '' }); | ||
| // use a 2-second timeout in order to allow for the animation to finish | ||
| // we don't actually care how long the animation takes | ||
| this.$timeout(function () { ctrl.fadeOutComplete(ripple); }, 650, false); |
There was a problem hiding this comment.
Extract specific timeouts into constants?
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
from
e0ed23b to
e6d20fa
Compare
| background-clip: padding-box; | ||
| overflow: hidden; | ||
| // The following hack causes Safari/Chrome to respect overflow hidden for ripples | ||
| -webkit-mask-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAA5JREFUeNpiYGBgAAgwAAAEAAGbA+oJAAAAAElFTkSuQmCC'); |
There was a problem hiding this comment.
Any chance we have a link to an article of why this works? Would be nice to add to the comment if available.
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
2 times, most recently
from
01c67b7 to
94efe87
Compare
| this.mousedown = false; | ||
| this.ripples = []; | ||
| this.color = this.getColor(); | ||
| this.background = this.getColor(0.5); |
There was a problem hiding this comment.
These should be deferred until the ripple render occurs (and then cached). See #4199 for details.
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
3 times, most recently
from
d3fd99f to
e5d1272
Compare
…n and providing more control over the ripples states adds support for centered ripples adds support for theme colors adds ripple directive, adds support for mdNoInk, adds support for dimBackground, adds support for fitRipple Ripples now respect a minimum timeout value
robertmesserle
force-pushed
the
wip/ripple/refactor
branch
from
e5d1272 to
88ca869
Compare
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
…n and providing more control over the ripples states Closes angular#4166 Closes angular#4199 Closes angular#3952 Closes angular#3346 Closes angular#2905 Closes angular#2636 Closes angular#2149 Closes angular#1597 Closes angular#1595 Closes angular#1398
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn @ThomasBurleson @rschmukler @topherfangio
Please review these changes. Please also check this out and look around for any breakages that I may have caused.
I will likely be going through and adding comments to make the code easier to navigate.