Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-sidenav was delayed #5850

Closed
Shyam-Chen opened this issue Nov 20, 2015 · 1 comment
Closed

md-sidenav was delayed #5850

Shyam-Chen opened this issue Nov 20, 2015 · 1 comment
Assignees
@devversion
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Milestone
1.1.0

Comments

@Shyam-Chen
Copy link

When I scroll down and open the md-sidenav, the md-sidenav was delayed.

default
@devversion
Copy link
Member

I copied the Codepen Link from your Screenshot into a plain link, so we can investigate better. Next time ... please share your link directly.

http://codepen.io/Shyam-Chen/pen/KdYdme

I tried to reproduce and figured out, this only happens if the sidenav is stored in the md-content ... If you put the sidenav outside of the md-content it will work perfect.

I created a fix for that, please take a look 👍

devversion added a commit to devversion/material that referenced this issue Nov 22, 2015
@devversion
fix(sidenav): fix delayed animation for sidenav if scrollTop != 0
a82e53c 
To checkout:
- Old Version: http://codepen.io/Shyam-Chen/pen/KdYdme
- New Version: http://codepen.io/DevVersion/pen/KdYxbK

Fixes angular#5850
@devversion devversion mentioned this issue Nov 22, 2015
Closed
@Shyam-Chen Shyam-Chen changed the title md-sidenav was delayed md-sidenav was delayed Nov 23, 2015
@Shyam-Chen Shyam-Chen changed the title md-sidenav was delayed md-sidenav was delayed Nov 23, 2015
devversion added a commit to devversion/material that referenced this issue Nov 23, 2015
@devversion
fix(sidenav): animate the sidenav on scrolled parent too.
5da083d 
See angular#5870

Closes angular#5870 Fixes angular#5850
devversion added a commit to devversion/material that referenced this issue Nov 23, 2015
@devversion
fix(sidenav): animate the sidenav on scrolled parent too.
c306513 
See angular#5870

Closes angular#5870 Fixes angular#5850
@devversion devversion mentioned this issue Nov 23, 2015
Closed
devversion added a commit to devversion/material that referenced this issue Nov 26, 2015
@devversion
fix(sidenav): animate the sidenav on scrolled parent too.
0f18d3a 
See angular#5870

Closes angular#5870 Fixes angular#5850
@EladBezalel EladBezalel added this to the 1.0.4 milestone Jan 9, 2016
@ThomasBurleson ThomasBurleson added i18n: bi-directional This issue is related to internationalization and right to left languages P1: urgent Urgent issues that should be addressed in the next minor or patch release. and removed i18n: bi-directional This issue is related to internationalization and right to left languages labels Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.4, Backlog Jan 15, 2016
@devversion devversion mentioned this issue Jan 29, 2016
Closed
@EladBezalel EladBezalel assigned devversion and unassigned EladBezalel Mar 3, 2016
@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Mar 4, 2016
devversion added a commit to devversion/material that referenced this issue Mar 31, 2016
@devversion
fix(sidenav): animate the sidenav on scrolled parent too.
7b78bd8 
See angular#5870

Closes angular#5870 Fixes angular#5850
@devversion devversion added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs and removed pr: merge ready This PR is ready for a caretaker to review labels Apr 13, 2016
@devversion devversion mentioned this issue Apr 13, 2016
Closed
@devversion devversion modified the milestones: 1.1.3, Backlog, 1.3.0 Apr 14, 2016
@devversion devversion modified the milestones: 1.3.0, 1.1.3 Apr 14, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.3.0, Backlog, 1.1.0 Apr 20, 2016
devversion added a commit to devversion/material that referenced this issue Apr 23, 2016
@devversion
fix(sidenav): update position of sidenav and backdrop if scrolled.
649628c 
Currently the sidenav is not animating when the parent is scrolled, this
was caused by the absolute position.

This commit, updates the position of the sidenav and backdrop when the
parent is scrolled.

It sets the position to the current scroll position and sets the height to
the parents `clientHeight`. Using a `100%` height, will impact the
performance heavily.

Fixes angular#5850.
@devversion devversion added has: Pull Request A PR has been created to address this issue and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Apr 23, 2016
@devversion devversion mentioned this issue Apr 23, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@ThomasBurleson @devversion @EladBezalel @Shyam-Chen