This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(sidenav): update position of sidenav and backdrop if scrolled. #8184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the sidenav is not animating when the parent is scrolled, this was caused by the absolute position. This commit, updates the position of the sidenav and backdrop when the parent is scrolled. It sets the position to the current scroll position and sets the height to the parents `clientHeight`. Using a `100%` height, will impact the performance heavily. Fixes angular#5850.
|
This is merged in edit - checking code looks like it's merged. not helping my case. anyone else having this issue still? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sidenav is not animating when the parent is scrolled, this
was caused by the absolute position.
This commit, updates the position of the sidenav and backdrop when the
parent is scrolled.
It sets the position to the current scroll position and sets the height to
the parents
clientHeight. Using a100%height, will impact theperformance heavily.
Fixes #5850.