This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): focus should behave as same as normal inputs #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/select-focus-behavior
branch
from
16ee9b9
to
32c17e7
Compare
This was referenced Dec 10, 2015
| @@ -466,6 +461,7 @@ function SelectDirective($mdSelect, $mdUtil, $mdTheming, $mdAria, $compile, $par | |||
| loadingAsync: attr.mdOnOpen ? scope.$eval(attr.mdOnOpen) || true : false | |||
| }).finally(function() { | |||
| selectScope.isOpen = false; | |||
| element.focus(); | |||
There was a problem hiding this comment.
I suspect this might interfere with the accessibility work that @rschmukler has recently done on this component. I'll ask him to take a look.
Fixes angular#6122 Fixes angular#6185 Closes angular#6132 Fixes angular#6274
devversion
force-pushed
the
fix/select-focus-behavior
branch
from
32c17e7
to
2afba77
Compare
This was referenced Dec 12, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blurandfocususingmd-input-containerFixes #6122 Fixes #6185 Closes #6132 Fixes #6274