This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): fix blur event not triggering, focus styles in containers #6275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE ME YET
This issue was the culprit for the select double label when invalid error that was discussed by @jelbourn and @topherfangio in slack.
I have no idea why this fix works. Specifically,
focus
fires butblur
does not with the jqliteon
methods. I'd love to hear from anyone who has ideas on why this might be (ping @jelbourn, @ThomasBurleson, @robertmesserle)I changed the focus listener for consistency, but this feels weird and I'd much rather get to the bottom of the issue than this quick-fix.