Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): fix blur event not triggering, focus styles in containers #6275

Closed
wants to merge 1 commit into from

Conversation

rschmukler
Copy link
Contributor

DO NOT MERGE ME YET

This issue was the culprit for the select double label when invalid error that was discussed by @jelbourn and @topherfangio in slack.

I have no idea why this fix works. Specifically, focus fires but blur does not with the jqlite on methods. I'd love to hear from anyone who has ideas on why this might be (ping @jelbourn, @ThomasBurleson, @robertmesserle)

I changed the focus listener for consistency, but this feels weird and I'd much rather get to the bottom of the issue than this quick-fix.

@rschmukler rschmukler added the needs: review This PR is waiting on review from the team label Dec 12, 2015
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Dec 12, 2015

@rschmukler
Copy link
Contributor Author

@gkalpak haha, yes obvious indeed. Sometimes a 2nd set of eyes is all it takes :P. Thanks

@rschmukler rschmukler closed this Dec 12, 2015
@devversion
Copy link
Member

I think that's duplicating #6207

@EladBezalel EladBezalel deleted the select-blur-fix branch January 15, 2016 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants