fix(tabs): crashing on chrome under certain conditions #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
changed the title
Prevents the tabs from either crashing Chrome (in Angular < 2.3) or throwing an animation error (in Angular >= 2.3). This was happening when the animations get triggered before the element is inserted into the DOM and thus doesn't have a computed `transform` value. Fixes angular#2151.
crisbeto
force-pushed
the
2151/tabs-crash-proper
branch
from
8732369
to
938dcca
Compare
jelbourn
requested review from
andrewseguin
and removed request for
jelbourn
|
@andrewseguin can you review this one? |
andrewseguin
approved these changes
Jan 17, 2017
andrewseguin
added
pr: lgtm
action: merge
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
* fix(tabs): crashing on chrome under certain conditions Prevents the tabs from either crashing Chrome (in Angular < 2.3) or throwing an animation error (in Angular >= 2.3). This was happening when the animations get triggered before the element is inserted into the DOM and thus doesn't have a computed `transform` value. Fixes angular#2151. * Fix IE errors. * Add a TODO. * Revert. * Add TODO for removing the workaround.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 13, 2017
Reverts a workaround that was preventing the tabs from crashing the user's browser in Angular < 2.3, due to an animations issue. This was introduced initially in angular#2411.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 17, 2017
Reverts a workaround that was preventing the tabs from crashing the user's browser in Angular < 2.3, due to an animations issue. This was introduced initially in angular#2411.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the tabs from either crashing Chrome (in Angular < 2.3) or throwing an animation error (in Angular >= 2.3). This was happening when the animations get triggered before the element is inserted into the DOM and thus doesn't have a computed
transformvalue.Fixes #2151.