This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): move interaction test off of the control flow #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrispusDH
reviewed
Nov 8, 2018
heathkit
approved these changes
Nov 9, 2018
| toMatch('index.html#/form'); | ||
| it('should be able to navigate to same url on fork', async() => { | ||
| await browser.get('index.html'); | ||
| newBrowser = await browser.forkNewDriverInstance(true).ready; |
There was a problem hiding this comment.
Apparently, this comes from:
Line 275 in ed955e5
I think this is so convoluted because it needed to support the control flow case as well. This should be cleaned up - forkNewDriverInstance() should just return a promise that resolves to the new browser instance, after its ready.
There was a problem hiding this comment.
Adding this to a queue of issues to clean up for the selenium 4 upgrade milestone
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.