Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

browser.forkNewDriverInstance should return a promise that resolves to the new browser #5031

Closed
cnishina opened this issue Nov 9, 2018 · 1 comment
Closed

browser.forkNewDriverInstance should return a promise that resolves to the new browser #5031

cnishina opened this issue Nov 9, 2018 · 1 comment
Assignees
@cnishina
Labels
P2 selenium4upgrade type: cleanup
Milestone
selenium4 upgrade

Comments

@cnishina
Copy link
Member

cnishina commented Nov 9, 2018

Reference #5019

protractor/lib/runner.ts

Line 275 in ed955e5

browser_.ready =

"I think this is so convoluted because it needed to support the control flow case as well. This should be cleaned up - forkNewDriverInstance() should just return a promise that resolves to the new browser instance, after its ready."

browser.forkNewDriverInstance should return a promise that resolves to the new browser.
@cnishina cnishina added this to the selenium4 upgrade milestone Nov 9, 2018
@cnishina cnishina self-assigned this Nov 9, 2018
@cnishina cnishina added the P2 label Nov 29, 2018
@cnishina cnishina mentioned this issue Dec 17, 2018
Merged
@cnishina
Copy link
Member Author

PR fix #5085

cnishina added a commit that referenced this issue Dec 18, 2018
@cnishina
chore(browser): remove timing issues with restart and fork (#5085)
2f7320d 
- remove .ready since forking should automatically return a browser
- getNewDriver should return a promised WebDriver that can be awaited
- fix interaction tests and local driver tests
- update unit tests for async await due to getNewDriver fix

closes #5031
cnishina added a commit to cnishina/protractor that referenced this issue Dec 19, 2018
@cnishina
chore(browser): remove timing issues with restart and fork (angular#5085
f9281a0 
)

- remove .ready since forking should automatically return a browser
- getNewDriver should return a promised WebDriver that can be awaited
- fix interaction tests and local driver tests
- update unit tests for async await due to getNewDriver fix

closes angular#5031
cnishina added a commit to cnishina/protractor that referenced this issue Mar 23, 2019
@cnishina
chore(browser): remove timing issues with restart and fork (angular#5085
4672265 
)

- remove .ready since forking should automatically return a browser
- getNewDriver should return a promised WebDriver that can be awaited
- fix interaction tests and local driver tests
- update unit tests for async await due to getNewDriver fix

closes angular#5031
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cnishina cnishina

Labels
P2 selenium4upgrade type: cleanup
Projects
None yet
Milestone
selenium4 upgrade
Development

No branches or pull requests
1 participant
@cnishina