This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(browser): remove timing issues with restart and fork #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
upgrade_jasmine
branch
10 times, most recently
from
98a4109
to
404b7b3
Compare
|
This appears to be having some problems. I thought it was something to do with a chrome and chromedriver mismatch. I'll have to find the culprit tests. This might take a while. |
cnishina
force-pushed
the
upgrade_jasmine
branch
5 times, most recently
from
451cbcc
to
14e7b58
Compare
- version @types/jasmine 3.3 requires a minimum of typescript 2.8 closes angular#5054
cnishina
force-pushed
the
upgrade_jasmine
branch
from
14e7b58
to
5eba77e
Compare
cnishina
force-pushed
the
upgrade_jasmine
branch
from
169261b
to
dd5d395
Compare
|
So this journey started out as a jasmine upgrade. And its no longer a jasmine upgrade. Maybe that can be the next step after this merge. |
cnishina
changed the title
cnishina
changed the title
heathkit
reviewed
Dec 18, 2018
|
I think in this PR could be fixed |
cnishina
force-pushed
the
upgrade_jasmine
branch
from
3916ffe
to
53a7612
Compare
|
|
heathkit
approved these changes
Dec 18, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
) - remove .ready since forking should automatically return a browser - getNewDriver should return a promised WebDriver that can be awaited - fix interaction tests and local driver tests - update unit tests for async await due to getNewDriver fix closes angular#5031
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
) - remove .ready since forking should automatically return a browser - getNewDriver should return a promised WebDriver that can be awaited - fix interaction tests and local driver tests - update unit tests for async await due to getNewDriver fix closes angular#5031
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.readysince forking should automatically return a browsercloses #5031