Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

[pkg]: "postinstall": "tsd install" #240

Closed
calebboyd opened this issue Jan 29, 2016 · 20 comments
Closed

[pkg]: "postinstall": "tsd install" #240

calebboyd opened this issue Jan 29, 2016 · 20 comments
Assignees

Comments

@calebboyd
Copy link

@mhevery, this statement breaks npm install for those who do not have tsd installed globally.

I'm not too sure how you'd like to alter that installation

@cloudlena
Copy link

I agree. As a person using the newer typings instead of tsd, this breaks my installation.

@cebor
Copy link

cebor commented Jan 29, 2016

same here

@psi-4ward
Copy link

+1

for now i npm i tsd

@cebor
Copy link

cebor commented Jan 31, 2016

strange thing is, that tsd is already added to devDeps

orestes pushed a commit to videogular/videogular2 that referenced this issue Jan 31, 2016
Fix the broken Travis CI build because of zone.js angular/zone.js#240
@calebboyd
Copy link
Author

@cebor, the problem is that dev dependencies are not installed for consumers

@cebor
Copy link

cebor commented Jan 31, 2016

yes you are right, so i think its better to remove the postinstall and document the tsd install as a manual step for contributors

@TheTedAdams
Copy link

+1 that this just broke our build.

postinstall tries to run tsd install on anyone installing this package from npm, which I don't think is what you were trying to do.

With tsd in devDependencies there is no guarantee tsd has been installed on the consumer. As a consumer I would also much rather postinstall was just removed, rather than adding a dependency on a successful tsd install. We have had tsd fail with API rate limiting so much that we have removed it from our build process and just added our typings folders to git...

@PatrickJS
Copy link
Member

+1 postinstall breaks angular2 beta.3 unless tsd is installed as a dependency

PatrickJS added a commit to PatrickJS/zone.js that referenced this issue Feb 3, 2016
@Kikketer
Copy link

Kikketer commented Feb 3, 2016

+1 Beta.3 fixes issues I have with multiple of the same components, but the dependency of installing tsd breaks my build on a build server. Moving back to beta.2 until this can be fixed.

@jrisk
Copy link

jrisk commented Feb 4, 2016

same here, npm install tsd -g did fix the ERR messages atleast

@lacolaco
Copy link

lacolaco commented Feb 5, 2016

in 0.5.13, tsd install is still remaining.

@boneskull
Copy link

@mhevery I think you want prepublish here.

  • prepublish: runs when npm install is explicitly executed in the zone.js dir (and before publication, of course)
  • postinstall: runs whenever zone.js is installed in the zone.js dir or via npm install zone.js

@boneskull
Copy link

(point being: it doesn't need to be an "extra step" developers of this project need to take)

@okunokentaro
Copy link

+1

@lacolaco
Copy link

lacolaco commented Feb 9, 2016

@mhevery Has there been any progress? Thanks.

@nwhite89
Copy link

nwhite89 commented Feb 9, 2016

👍 As a fix in my own project I have had to do

"preinstall": "npm i tsd"

This fixes issues I am having on Circle for example just incase that helps anyone else having this issue rather than having to have tsd globally until this is fixed.

@dpsthree
Copy link

TSD is deprecated in favor of Typings (https://github.com/typings/typings) - see DefinitelyTyped/tsd#269 for more information

@mikekidder
Copy link

Version 5.14 has moved tsd to prepublish. I put in a PR #253 for the deprecation, if accepted

@alexeagle
Copy link
Contributor

Thanks for the PR, @mikekidder .
I'll close this issue since users should be able to npm install 0.5.14

@boneskull
Copy link

okay, sorry for the PR then!

seansfkelley pushed a commit to seansfkelley/react-layered-chart that referenced this issue May 28, 2016
…d installed.

At the moment, this is the accepted way to do this.

For more on why this still works for dev work:
npm/npm#3059
npm/npm#10074

Example of this being a problem:
angular/zone.js#240
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.