Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Use typings; tsd is deprecated #253

Closed
wants to merge 2 commits into from

Conversation

mikekidder
Copy link

Was going to push earlier, but saw you had updated tsd. :)

package.json - removed tsd, adds typings.... the rest is just from alpha sorting

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mikekidder
Copy link
Author

CLA, I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@@ -3,7 +3,6 @@
"version": "0.5.14",
"description": "Zones for JavaScript",
"main": "build/lib/zone.js",
"typings": "build/lib/core.d.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this line - this is an output of the package. It allows users to
import {Zone} from 'zone.js';
and the typescript type-checker can find it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know. Wasn't sure if that was a tsd leftover.

@alexeagle
Copy link
Contributor

LGTM after that fix

@alexeagle alexeagle self-assigned this Feb 14, 2016
@mikekidder
Copy link
Author

Closing as this looks to be covered in 0.6.1

@mikekidder mikekidder closed this Mar 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants