-
Notifications
You must be signed in to change notification settings - Fork 408
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLA, I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@@ -3,7 +3,6 @@ | |||
"version": "0.5.14", | |||
"description": "Zones for JavaScript", | |||
"main": "build/lib/zone.js", | |||
"typings": "build/lib/core.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this line - this is an output of the package. It allows users to
import {Zone} from 'zone.js';
and the typescript type-checker can find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good to know. Wasn't sure if that was a tsd leftover.
LGTM after that fix |
Closing as this looks to be covered in 0.6.1 |
Was going to push earlier, but saw you had updated tsd. :)
package.json - removed tsd, adds typings.... the rest is just from alpha sorting