Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to the density conversions in the .json file #173

Merged
merged 2 commits into from
Jul 8, 2016

Conversation

massonib
Copy link
Contributor

No description provided.

@angularsen
Copy link
Owner

Thanks!
I double checked the changes and look good, but I also glanced through the rest and found this. Can you check and correct if you agree?

"SingularName": "PoundPerCubicInch",
"PluralName": "PoundsPerCubicInch",
"FromUnitToBaseFunc": "x*27679.904710191",
"FromBaseToUnitFunc": "x/27679.904710191",

Google gives 1 kg / m³ = 3.61273e-5 lb/in³
unitjuggler.com gives 3.6127298147753E-5 lb/in3

@massonib
Copy link
Contributor Author

massonib commented Jul 7, 2016

1/3.61273e-5 = 27679.904710191. So at that point it is just semantics.

@massonib
Copy link
Contributor Author

massonib commented Jul 7, 2016

I have updated the density.JSON file to follow consistent conversion styling (e.g. always multiply for FromBaseToUnit and divide for FromUnitToBase). I'm not a computer with Powershell 3, so I couldn't run the code generator.

@angularsen
Copy link
Owner

You are absolutely right, I missed that. I suppose it should go into the guidelines what form is the convention.

@angularsen angularsen merged commit d1b3ba4 into angularsen:master Jul 8, 2016
@angularsen
Copy link
Owner

Nuget 3.38.1 out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants