Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chinese abbreviations for area,length,mass units #867

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Add chinese abbreviations for area,length,mass units #867

merged 3 commits into from
Dec 17, 2020

Conversation

chinasqzl
Copy link

Add chinese abbreviations for area,length,mass units

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #867 (b4f838e) into master (9070996) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #867   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files         287      287           
  Lines       42987    42987           
=======================================
  Hits        35720    35720           
  Misses       7267     7267           
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100.00% <ø> (ø)
UnitsNet/QuantityInfo.cs 94.20% <0.00%> (ø)
UnitsNet/QuantityValue.cs 79.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9070996...b4f838e. Read the comment docs.

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I just need you to verify the prefixes work as intended.

Update:
You need to run generate-code.bat to generate all the new unit abbreviations.

Common/UnitDefinitions/Length.json Show resolved Hide resolved
@angularsen angularsen merged commit 8c17354 into angularsen:master Dec 17, 2020
@angularsen
Copy link
Owner

Nuget is on the way out, thank you for the contribution!

Release UnitsNet/4.79.0 · angularsen/UnitsNet

@chinasqzl chinasqzl deleted the chinese branch December 18, 2020 08:10
@angularsen
Copy link
Owner

@chinasqzl Hi, there is some recent discussion on reverting 厘米 back to cm and instead localizing 厘米 for the unit enum name "Centimeter".

Assuming you know Chinese, could you please help determine what is correct?

#1171 Localization related Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants