Add TemperatureGradient and deprecate LapseRate #991
Conversation
Huh, that is super weird. Seems you are on MacOS or Linux maybe, I am on Windows. Could it be anything there? It should be alphabetically sorted. Could you debug the codegen console app and maybe see why it produces a different ordering? Maybe there is some subtle difference on LINQ not preserving the ordering or something. I would expect adding a OrderBy() at the right place should fix this. |
Sounds good to me 👍 |
|
That's right, I am using Intellij on a Mac. I will debug the CodeGen later today and try to sort it out 😀 |
Directory.GetFiles doesn't guarantee the order of the file names. In windows it seems to be retrieving them alphabetically sorted, but that's not the case for Mac. Have taken the liberty to rename `jsonFile` to `jsonFileName`, since the return of Directory.GetFiles is an array of file names. The content of the file itself is read at a later point.
The [Obsolete] attribute was being generated on top of the XML documentation, which is an invalid location, so I have moved it right after it and before the [DataContract] attribute. Related: - angularsen#474
It will be replaced by TemperatureGradient
… from LapseRate I have removed the TemperatureDelta/Length = LapseRate operator since it would collide with the same overload that equals TemperatureGradient. This is a breaking change, but it was decided that we can do it anyways since it's easy to replace and you will get a compiler error.
|
It seems the culprit of the sorting issue was the Ref.: https://docs.microsoft.com/en-us/dotnet/api/system.io.directory.getfiles?view=net-6.0 Have added the fix in this commit together with a small renaming. |
|
Great that you figured it out! |
|
|
||
| protected override double DegreesCelciusPerMeterInOneKelvinPerMeter => 1; | ||
|
|
||
| protected override double DegreesFahrenheitPerFootInOneKelvinPerMeter => 0.54864; |
There was a problem hiding this comment.
angularsen
changed the title
|
Nuget should be out shortly. |
I have added a new Quantity called TemperatureGradient and deprecated LapseRate, as agreed in #988
In addition, I did a small change in the CodeGen project to place the
[Obsolete]attribute below the XML documentation, to avoid getting some warnings.This is how it was generated before my change
I have a small issue though: after cloning the repo, and before doing any change at all, I run the CodeGen and I see tons of changes being made. It seems that much of the code was alphabetically ordered before, and the CodeGen by default in my machine overrides that (check a923584)
Any suggestion on how to solve this ?