Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TemperatureGradient and deprecate LapseRate #991

Merged
merged 6 commits into from
Nov 23, 2021
Merged

Add TemperatureGradient and deprecate LapseRate #991

merged 6 commits into from
Nov 23, 2021

Commits on Nov 23, 2021

  1. Order the quantity json files alphabetically before running CodeGen 

    Directory.GetFiles doesn't guarantee the order of the file names.
In windows it seems to be retrieving them alphabetically sorted,
but that's not the case for Mac.

Have taken the liberty to rename `jsonFile` to `jsonFileName`, since
the return of Directory.GetFiles is an array of file names. The content
of the file itself is read at a later point.
    @dglozano
    dglozano committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    3dfe9a4 View commit details
    Browse the repository at this point in the history

  2. Move Obsolete attribute in the generator below the XML documentation 

    The [Obsolete] attribute was being generated on top of the XML documentation, which is an invalid location, so I have moved it right after it and before the
[DataContract] attribute.

Related:
 - angularsen#474
    @dglozano
    dglozano committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c1aca3c View commit details
    Browse the repository at this point in the history

  3. Mark LapseRate as Obsolete 

    It will be replaced by TemperatureGradient
    @dglozano
    dglozano committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    456547e View commit details
    Browse the repository at this point in the history

  4. Add TemperatureGradient Quantity

    @dglozano
    dglozano committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    04a3d21 View commit details
    Browse the repository at this point in the history

  5. Add operators extensions to TemperatureGradient and remove duplicates… 

    … from LapseRate

I have removed the TemperatureDelta/Length = LapseRate operator since it
would collide with the same overload that equals TemperatureGradient. This is
a breaking change, but it was decided that we can do it anyways since
it's easy to replace and you will get a compiler error.
    @dglozano
    dglozano committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    99b8a6e View commit details
    Browse the repository at this point in the history

  6. Remove None Include=""

    @angularsen
    angularsen committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    68e8516 View commit details
    Browse the repository at this point in the history