Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flask cors to allow running multiple servers locally #52

Conversation

mtreacy002
Copy link
Member

@mtreacy002 mtreacy002 commented Jun 14, 2020

Description

Added cors to allow requests from frontend (cross origin) for testing BIT functionality like register user PR#18

Fixes #51

How Has This Been Tested?

Register new user from BIT React UI while running BIT and MS backend servers.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • [x]existing unit tests pass locally with my changes

Additional note

  • new dependencies added inside requirements.txt so need to reinstall dependencies by running pip install -r requirements.txt

@mtreacy002
Copy link
Member Author

@anitab-org/bridgeintech-maintainers . We need to have this approve for mentors to be able to test Register UI since they need to run BIT and MS backend locally.

@meenakshi-dhanani
Copy link

So I started my frontend and made a register request to the backend. I was able to do so successfully. So the PR seems fine :) Approving

@foongminwong foongminwong self-requested a review June 14, 2020 20:10
Copy link

@foongminwong foongminwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to install the flask-cors dependency locally and test the register ui functionality successfully

@meenakshi-dhanani meenakshi-dhanani merged commit f3bb484 into anitab-org:develop Jun 15, 2020
@mtreacy002 mtreacy002 deleted the add-cors-to-allow-running-multiple-servers-locally branch June 15, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: flask-cors dependency is needed to allow cross-origin requests
3 participants