-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue8 register ui - new pr #18
Issue8 register ui - new pr #18
Conversation
…h-web into develop merge develop origin upstream
The changes made in this PR were tested locally. Following are the results:
|
Thank you @foongminwong for you feedback... Loving how you test the PR as you review 😉 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foongminwong reviewed the functionality, seems fine. Reviewed the code. Works as expected
@foongminwong if all looks good, can you approve? |
Description
This PR is to provide Register UI and backend consumption.
Fixes #8 and replaces PR #15
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
By creating new user as well as trying to register with existing user's data
Steps to test:
Note: I recommend tester/reviewer to create a separate branch on MS backend to run MS server as there a few lines of code need to be added inside the MS backend run.py which is specific to BIT only (in the future I will open an issue on MS side to accommodate this). Please refer to
run.py
inside code changes for BIT PR#52 and update your pip dependencies as per that PR additional notes.Checklist:
Code/Quality Assurance Only