Skip to content

Comments

feat(CardAnalysisWidget): add configurable theme control to widget config window#18994

Open
xenonnn4w wants to merge 1 commit intoankidroid:mainfrom
xenonnn4w:dynamicOff
Open

feat(CardAnalysisWidget): add configurable theme control to widget config window#18994
xenonnn4w wants to merge 1 commit intoankidroid:mainfrom
xenonnn4w:dynamicOff

Conversation

@xenonnn4w
Copy link
Contributor

@xenonnn4w xenonnn4w commented Jul 31, 2025

Purpose / Description

Add a theme control option to the Card Analysis Widget config window,
allowing users to enable or disable dynamic theming for this widget
individually. When disabled, the widget uses Ankidroid theme
colors instead of wallpaper-based colors.

Fixes

How Has This Been Tested?

Card Analysis Widget (Updated)

(Outdated Version)

Whatdfx.mp4

(Latest Version)

card09.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add a section in Settings for widgets. Don't add a global setting for all the widgets. Add an option inside each widget configuration page to set the widget theme individually.

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jul 31, 2025
@xenonnn4w
Copy link
Contributor Author

xenonnn4w commented Jul 31, 2025

Don't add a section in Settings for widgets

as per this discussion with @david-allison here, https://discord.com/channels/368267295601983490/1235296459621007471/1397911335802503190 , it felt the best option.
I tried this (like that of your suggestion) way before coming to this conclusion but i was not able to come up with an idea of placement of this setting in the config window, like see here

View screenshot
Screenshot_20250731_201808

@xenonnn4w xenonnn4w removed the Needs Author Reply Waiting for a reply from the original author label Jul 31, 2025
@BrayanDSO
Copy link
Member

A gear icon somewhere, an equivalent of a list preference at the top or bottom, an appearance fab at the top of the add one,...

There are many better alternatives.

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jul 31, 2025
@xenonnn4w
Copy link
Contributor Author

xenonnn4w commented Aug 3, 2025

View screenshots
Screenshot_20250804_000456 Screenshot_20250804_000501 Screenshot_20250804_001258

@BrayanDSO looks good?

@BrayanDSO
Copy link
Member

BrayanDSO commented Aug 4, 2025

change the big button icon to a Gear icon, since both of its suboptions are about confuring the widget. It probably can be further simplified, but that's good enough for now.

Use "single choice items" in the dialog, with the options being Dynamic and AnkiDroid.

Use just Widget theme as the dialog title, with no message, just the single choice selector.

@xenonnn4w xenonnn4w changed the title feat: add global widget dynamic theming control feat(CardAnalysisWidget): add configurable theme control to widget config window Aug 11, 2025
@xenonnn4w xenonnn4w added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Aug 11, 2025
@xenonnn4w
Copy link
Contributor Author

Updated description video to reflect latest changes.

@BrayanDSO
Copy link
Member

Put Add deck as the primary action (the big one in the bottom), and the theme as the secondary one (with a palette icon)

{5F976DD8-8380-490A-9BFF-B36B22CA675C}

(pallete icon)

@xenonnn4w
Copy link
Contributor Author

change the big button icon to a Gear icon

So the main button will be the gear button, clicking on it will lead to two more i.e add deck ("plus icon")(this will be at place of gear icon) and widget theme ("pallete icon")?

@BrayanDSO
Copy link
Member

yes

@xenonnn4w
Copy link
Contributor Author

Screen_recording_20250814_193850.webm

@altius4444
Copy link

Any updates on this?

@xenonnn4w xenonnn4w requested a review from BrayanDSO October 26, 2025 11:06
@xenonnn4w xenonnn4w force-pushed the dynamicOff branch 2 times, most recently from 303f5cf to dd20c10 Compare December 14, 2025 07:37
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Dec 15, 2025
@xenonnn4w xenonnn4w removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Dec 17, 2025
@xenonnn4w
Copy link
Contributor Author

card09.mp4

@xenonnn4w xenonnn4w requested review from david-allison and removed request for BrayanDSO December 17, 2025 13:51
@xenonnn4w xenonnn4w requested a review from BrayanDSO December 17, 2025 13:51
@david-allison
Copy link
Member

david-allison commented Dec 22, 2025

I'd propose blocking this on the following, as it'll impact how theming occurs. Once it's in, we can likely simplify the code:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants