feat: change themes configuration#19700
Merged
BrayanDSO merged 3 commits intoankidroid:mainfrom Jan 3, 2026
Merged
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
BrayanDSO
added
the
squash-merge
criticalAY
approved these changes
Dec 6, 2025
| <item>@string/full_screen_system</item> | ||
| <item>@string/full_screen_complete</item> | ||
| </string-array> | ||
|
|
david-allison
approved these changes
Dec 7, 2025
AnkiDroid/src/main/java/com/ichi2/anki/preferences/AppearanceSettingsFragment.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/preferences/AppearanceSettingsFragment.kt
Show resolved
Hide resolved
david-allison
added
Needs Second Approval
BrayanDSO
force-pushed
the
ref/theme
branch
2 times, most recently
from
22d3a52 to
46059e8
Compare
5 tasks
5 tasks
lukstbit
approved these changes
Jan 3, 2026
lukstbit
added
Pending Merge
Member
|
Pending on me squashing and |
now you select the color scheme (follow system, day, night) under the `Theme` setting, and the themes themselves are selected under `Day theme` and `Night theme` this makes things slightly more simple/predictable and allow the code to be simpler
BrayanDSO
removed
the
squash-merge
Member
Author
|
Squashed the necessary commits |
Contributor
|
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
now you select the color scheme (follow system, day, night) under the
Themesetting, and the themes themselves are selected underDay themeandNight themethis makes things slightly more simple/predictable and allow the code to be simpler
also makes possible to have different and custom color palettes, while specifying if you want a light or dark theme.
Approach
PrefEnums to represent the app, day, and night themesHow Has This Been Tested?
Emulator 31
Before upgrading the preferences
After ugprading the preferences
Emulator 25
Checklist
Please, go through these checks before submitting the PR.