Add new filtered deck options implementation by lukstbit · Pull Request #19669 · ankidroid/Anki-Android

lukstbit · 2025-12-01T18:43:22Z

Purpose / Description

Initially, while working on #18875, I implemented the filtered deck related part outside of the (old)FilteredDeckOptions like CreateDeckDialog was doing. After thinking about this I decided that it is a better idea to implement a new screen for filtered decks following desktop behavior.

Changes:

use material design for screen
get away from deprecated preferences code
automatic configuration changes handling
slightly improve user ux as entering most values requires only two touches now
still a bit more functionality to add to match desktop(browser search). I implemented it but this already got really big

The line count is big but two thirds of it is the layout, tests and views setup.

Video with general behavior(Don't keep activities is on):

Screen_recording_20251202_092039.webm

Images with how it looks with different themes

Fixes

Related to Remove DeckSpinnerSelection and recode DeckSelectionDialog #18875

How Has This Been Tested?

Manually checked the behavior against desktop behavior, ran tests.

Checklist

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

github-actions · 2025-12-01T18:43:34Z

Important

Maintainers: This PR contains Strings changes

Sync Translations before merging this PR and wait for the action to complete
Review and merge the auto-generated PR in order to sync all user-submitted translations
Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

david-allison · 2025-12-01T22:28:11Z

Thank you so much!!!

From the video (no code viewed):

The first "limit to" box doesn't bring up a numbers keyboard
Could we add a "(?)" somewhere to explain
- Briefly what a filtered deck is
- it's the same Anki search syntax as 'Browse'.
I don't like the buttons, I think it's partially our theme, but could we try this design instead?

ZornHadNoChoice · 2025-12-02T02:23:34Z

If I may give my feedback:

The titles "Filter" and "Options" should be a bit more distinguished from the other text.
The sort selection box can be typed in?
Use switches (not radio buttons) if the items in a list can be independently controlled.

lukstbit · 2025-12-02T06:01:20Z

Feedback considered:

The first "limit to" box doesn't bring up a numbers keyboard

It should now.

Could we add a "(?)" somewhere to explain
Briefly what a filtered deck is
it's the same Anki search syntax as 'Browse'.

I already added a help menu item linking to the docs webpage. Adding extra TLDR text in the view feels verbose. Helpful for beginners the very first times when creating filtered decks, useless and just taking space for anyone else.
Maybe some one time notification?

I don't like the buttons, I think it's partially our theme, but could we try this design instead?

Implemented it but note that I removed the Options for part of the title, there simply isn't enough space for the full original title: Options for Filtered deck 15:15. I updated the images and video at the top.

The titles "Filter" and "Options" should be a bit more distinguished from the other text.

Yes I didn't add any styling to them. They should now be more consistent, I also added extra padding to their related content, it provides better structuring IMO.

The sort selection box can be typed in?

Yes, that's how that widget works. Not enthusiastic about it either but I'm fine with it. The user can either use the dropdown to bring the popup or enter text to filter the values.

Use switches (not radio buttons) if the items in a list can be independently controlled.

Yes, thanks. I was looking too much at the desktop ui.

ZornHadNoChoice · 2025-12-02T10:13:56Z

I think the remaining checkboxes should also be switches. Also, it would be better if all switches were below "Options", the second filter/delays were above it, and the switches font were normal weight.

If you're fine with deviating slightly from Anki Desktop

the "Name" box is unnecessary and the "Build" button could be replaced with a checkmark icon.

david-allison · 2025-12-04T16:53:15Z

Turn off spellchecking in the dropdown

Can you use app:suffixText (possibly with a <plurals> here):

david-allison

Wow, excellent!

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

AnkiDroid/src/main/res/menu/filtered_options.xml

AnkiDroid/src/test/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModelTest.kt

lukstbit · 2025-12-06T15:06:19Z

I updated the images.

I think the remaining checkboxes should also be switches.

Tried it and like it enough to implement it, thanks.

Also, it would be better if all switches were below "Options", the second filter/delays were above it, and the switches font were normal weight.

Did this on purpose.
The second filter switch I placed outside because I don't think the desktop behavior is that great here(switch in a different place => content appearing somewhere above it). I like the local aspect of the current behavior.
The delays inputs are only visible when reschedule is unchecked and again I like the local aspect of it.

the "Name" box is unnecessary

Probably but it's also consistent with all the other inputs so I'm keeping it.

and the "Build" button could be replaced with a checkmark icon.

Doesn't work, we have two cases Build and Rebuild and the text is important.

Turn off spellchecking in the dropdown
Can you use app:suffixText (possibly with a here):

Implemented both requests, but note that I used the backend string for seconds.

david-allison

Looks great

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

lukstbit · 2025-12-07T14:19:29Z

Note that I marked the test: building a filtered deck with no cards fails unless allow empty is checked as flaky on windows. Passed on linux every time I ran the test but in Windows CI it sometimes fails.

mikehardy · 2025-12-10T14:25:17Z

reviewer note: I'm expecting to review this and hopefully approve shortly but -

I'd like to wait to merge it for just about a week - until 20251217

Goal is to preserve the ability to sync strings via cherry-pick to the release branch for just a little bit after stable goes live and the initial burst of translations comes in when people notice there are new strings in the app

This PR deletes strings and that would crash the app if I cherry-pick strings sync and those removed strings were accessed by the stable branch code that still exists.

To be used in filtered decks options screen.

Uses the implementation of SingleFragmentActivity and delegates the configuration changes back to the system. Handling configuration changes on our own is not something useful for most fragments(excluding page fragment which are mostly a WebView) and has the potential to introduce quite a few bugs.

Note: this doesn't implement completely the desktop functionality for this screen, everything missing will be added in a future PR.

david-allison

All optional/nitpicks. Looks GREAT!!!

david-allison · 2026-01-12T14:37:19Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

+                                        showThemedToast(
+                                            context = requireContext(),
+                                            textResource = R.string.something_wrong,
+                                            shortLength = false,


This doesn't seem necessary after an error dialog has appeared

david-allison · 2026-01-12T14:38:04Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

+        binding.filterLimitInputLayout.error =
+            if (filter1State.limit.toIntOrNull() == null) TR.errorsInvalidInputEmpty() else null
+        binding.filterCardsInput.setAdapterIfChanged(state.cardOptions, filter1State.index)
+        // rescheduling(done here because in filter 2 setup we might exit early)


Suggested change

// rescheduling(done here because in filter 2 setup we might exit early)

// rescheduling (done here because in filter 2 setup we might exit early)

david-allison · 2026-01-12T14:43:06Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

+        /**
+         * Starts a [ConfigAwareSingleFragmentActivity] containing this fragment. If [search] or
+         * [search2] are provided, they will be used as the default search text.
+         * @param did the [DeckId] of a filtered deck. If it's non-zero, load and modify its settings


nit: consider different methods for 'create' and 'edit'

david-allison · 2026-01-12T14:43:55Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

+    private val did: DeckId
+        get() = savedStateHandle.get<Long>(ARG_DECK_ID) ?: 0L


document the meaning of 0

consider .require<DeckId> - the value should always be sent to the fragment

david-allison · 2026-01-12T14:46:31Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

+                _state.update { Initializing(throwable = backendQueryResult.exceptionOrNull()) }
+                return@launch
+            }
+            val (filteredDeckData, cardsOptions) = backendQueryResult.getOrThrow()


nit

This pattern seems unusual:

check isFailure

return if true

Then call getOrThrow

Is there a partition method, or would getOrElse be cleaner?

david-allison · 2026-01-12T14:49:23Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

+        val firstFilter = config.getSearchTerms(0)
+        val secondFilter = if (config.searchTermsCount > 1) config.getSearchTerms(1) else null
+        return FilteredDeckOptions(
+            // backend uses 0 for creating a new filtered deck but we use null instead


nit; We use a mix, probably should standardize

david-allison · 2026-01-12T14:50:18Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

+                    Deck.Filtered.SearchTerm
+                        .newBuilder()
+                        .setSearch(filter2State.search)
+                        .setLimit(filter2State.limit.toIntOrNull() ?: 0)
+                        .setOrder(
+                            Deck.Filtered.SearchTerm.Order
+                                .forNumber(filter2State.index),
+                        ),
+                )


Optional: use Kotlin DSL

searchTerms got better, IMO

Deck.Filtered may be cleaner as a builder instead of using dsl

Subject: [PATCH] a --- Index: AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt b/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt --- a/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt (revision 6b787c2253308cb9858ed7137b9dcf103f6822fb) +++ b/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt (date 1768596709543) @@ -21,7 +21,10 @@ import androidx.lifecycle.viewModelScope import anki.collection.OpChangesWithId import anki.decks.Deck +import anki.decks.DeckKt.FilteredKt.searchTerm +import anki.decks.DeckKt.filtered import anki.decks.FilteredDeckForUpdate +import anki.decks.copy import anki.decks.filteredDeckForUpdate import com.ichi2.anki.CollectionManager.withCol import com.ichi2.anki.filtered.FilteredDeckOptionsFragment.Companion.ARG_DECK_ID @@ -284,37 +287,32 @@ id = current.id ?: 0 name = current.name allowEmpty = current.allowEmpty - val configBuilder = - Deck.Filtered - .newBuilder() - .setReschedule(current.shouldReschedule) - .setPreviewAgainSecs(current.delayAgain.toIntOrNull() ?: 60) - .setPreviewHardSecs(current.delayHard.toIntOrNull() ?: 600) - .setPreviewGoodSecs(current.delayGood.toIntOrNull() ?: 0) - .addSearchTerms( - Deck.Filtered.SearchTerm - .newBuilder() - .setSearch(current.filter1State.search) - .setLimit(current.filter1State.limit.toIntOrNull() ?: 0) - .setOrder( - Deck.Filtered.SearchTerm.Order - .forNumber(current.filter1State.index), - ), + val config = + filtered { + reschedule = current.shouldReschedule + previewAgainSecs = current.delayAgain.toIntOrNull() ?: 60 + previewHardSecs = current.delayHard.toIntOrNull() ?: 600 + previewGoodSecs = current.delayGood.toIntOrNull() ?: 0 + searchTerms.add( + searchTerm { + search = current.filter1State.search + limit = current.filter1State.limit.toIntOrNull() ?: 0 + order = Deck.Filtered.SearchTerm.Order.forNumber(current.filter1State.index) + } ) + } val filter2State = current.filter2State if (current.isSecondFilterEnabled && filter2State != null) { - configBuilder.addSearchTerms( - Deck.Filtered.SearchTerm - .newBuilder() - .setSearch(filter2State.search) - .setLimit(filter2State.limit.toIntOrNull() ?: 0) - .setOrder( - Deck.Filtered.SearchTerm.Order - .forNumber(filter2State.index), - ), - ) + config.copy { + searchTerms.add(searchTerm { + search = filter2State.search + limit = filter2State.limit.toIntOrNull() ?: 0 + order = Deck.Filtered.SearchTerm.Order + .forNumber(filter2State.index) + }) + } } - config = configBuilder.build() + this.config = config } companion object {

BrayanDSO · 2026-01-16T19:44:29Z

the first input is not aligned with the others

BrayanDSO · 2026-01-16T20:13:32Z

If the loading takes some time, the empty button at the top is weird.

Screen_recording_20260116_171119.webm

Also, it should not do anything while loading. At the moment, it waits the page to load and instantly build a deck

Screen_recording_20260116_171404.webm

One option is to use a simple check icon button instead of using text

Tested with

Subject: [PATCH] a
---
Index: AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt b/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt
--- a/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt	(revision 6b787c2253308cb9858ed7137b9dcf103f6822fb)
+++ b/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt	(date 1768593964386)
@@ -49,6 +49,7 @@
 import com.ichi2.utils.show
 import com.ichi2.utils.title
 import dev.androidbroadcast.vbpd.viewBinding
+import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
 /**
@@ -117,6 +118,7 @@
                         }
 
                         is FilteredDeckOptions -> {
+                            delay(4000)
                             bindState(state)
                             // show any errors we might have
                             if (state.throwable != null) {

BrayanDSO

Currently, the only blocking thing for me is the input boxes misalignment

BrayanDSO · 2025-12-07T12:10:02Z

AnkiDroid/src/main/java/com/ichi2/anki/utils/ConfigAwareSingleFragmentActivity.kt

+            Intent(context, ConfigAwareSingleFragmentActivity::class.java).apply {
+                putExtra(FRAGMENT_NAME_EXTRA, fragmentClass.jvmName)
+                putExtra(FRAGMENT_ARGS_EXTRA, arguments)
+                val t: SingleFragmentActivity


BrayanDSO · 2026-01-16T20:01:09Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

+import kotlinx.coroutines.launch
+
+/**
+ * Represents the screen where a filtered deck can be built or rebuilt after updating it's properties.


Suggested change

* Represents the screen where a filtered deck can be built or rebuilt after updating it's properties.

* Represents the screen where a filtered deck can be built or rebuilt after updating its properties.

BrayanDSO · 2026-01-16T20:09:58Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt

+
+/**
+ * Represents the screen where a filtered deck can be built or rebuilt after updating it's properties.
+ *


Could you please document the behavior of the two loading indicators?

I had to check in the code what each of them do.

BrayanDSO · 2026-01-16T20:21:32Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

+    }
+
+    /** Queries the backend for cards search options and [FilteredDeckForUpdate] guarding against any exception. */
+    private fun Collection.safeBackendDataQuery(did: DeckId): Result<Pair<FilteredDeckForUpdate, List<String>>> =


Document filtered decks backend data query exceptions

safeBackendDataQuery() and safeAddOrUpdateFilteredDeck() guard against errors while building a filtered deck.

The errors that can be thrown should be documented so other developers know what they should expect

text to peel to a new issue ⤴️

BrayanDSO · 2026-01-16T20:54:26Z

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt

+                    Deck.Filtered.SearchTerm
+                        .newBuilder()
+                        .setSearch(filter2State.search)
+                        .setLimit(filter2State.limit.toIntOrNull() ?: 0)
+                        .setOrder(
+                            Deck.Filtered.SearchTerm.Order
+                                .forNumber(filter2State.index),
+                        ),
+                )


searchTerms got better, IMO

Deck.Filtered may be cleaner as a builder instead of using dsl

Subject: [PATCH] a --- Index: AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt b/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt --- a/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt (revision 6b787c2253308cb9858ed7137b9dcf103f6822fb) +++ b/AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsViewModel.kt (date 1768596709543) @@ -21,7 +21,10 @@ import androidx.lifecycle.viewModelScope import anki.collection.OpChangesWithId import anki.decks.Deck +import anki.decks.DeckKt.FilteredKt.searchTerm +import anki.decks.DeckKt.filtered import anki.decks.FilteredDeckForUpdate +import anki.decks.copy import anki.decks.filteredDeckForUpdate import com.ichi2.anki.CollectionManager.withCol import com.ichi2.anki.filtered.FilteredDeckOptionsFragment.Companion.ARG_DECK_ID @@ -284,37 +287,32 @@ id = current.id ?: 0 name = current.name allowEmpty = current.allowEmpty - val configBuilder = - Deck.Filtered - .newBuilder() - .setReschedule(current.shouldReschedule) - .setPreviewAgainSecs(current.delayAgain.toIntOrNull() ?: 60) - .setPreviewHardSecs(current.delayHard.toIntOrNull() ?: 600) - .setPreviewGoodSecs(current.delayGood.toIntOrNull() ?: 0) - .addSearchTerms( - Deck.Filtered.SearchTerm - .newBuilder() - .setSearch(current.filter1State.search) - .setLimit(current.filter1State.limit.toIntOrNull() ?: 0) - .setOrder( - Deck.Filtered.SearchTerm.Order - .forNumber(current.filter1State.index), - ), + val config = + filtered { + reschedule = current.shouldReschedule + previewAgainSecs = current.delayAgain.toIntOrNull() ?: 60 + previewHardSecs = current.delayHard.toIntOrNull() ?: 600 + previewGoodSecs = current.delayGood.toIntOrNull() ?: 0 + searchTerms.add( + searchTerm { + search = current.filter1State.search + limit = current.filter1State.limit.toIntOrNull() ?: 0 + order = Deck.Filtered.SearchTerm.Order.forNumber(current.filter1State.index) + } ) + } val filter2State = current.filter2State if (current.isSecondFilterEnabled && filter2State != null) { - configBuilder.addSearchTerms( - Deck.Filtered.SearchTerm - .newBuilder() - .setSearch(filter2State.search) - .setLimit(filter2State.limit.toIntOrNull() ?: 0) - .setOrder( - Deck.Filtered.SearchTerm.Order - .forNumber(filter2State.index), - ), - ) + config.copy { + searchTerms.add(searchTerm { + search = filter2State.search + limit = filter2State.limit.toIntOrNull() ?: 0 + order = Deck.Filtered.SearchTerm.Order + .forNumber(filter2State.index) + }) + } } - config = configBuilder.build() + this.config = config } companion object {

BrayanDSO · 2026-01-16T21:29:52Z

AnkiDroid/src/main/java/com/ichi2/anki/utils/ConfigAwareSingleFragmentActivity.kt

+ * Note: do NOT add any configuration changes in the manifest for this activity. Either use [SingleFragmentActivity]
+ * or declare your own copy.
+ */
+class ConfigAwareSingleFragmentActivity : SingleFragmentActivity() {


For discussion (for a separate issue):

I think that SingleFragmentActivity should be the one NOT handling configuration changes, and implementers should deal with the configuration changes themselves.

Our configuration handling is mostly due to the use of WebViews, so we could have some kind of class named PageActivity, WebViewActivity or even AnkiActivity (and rename the old AnkiActivity to BaseActivity).

Or we could just keep its managed configuration changes as a minimal set and keep things simple.

github-actions · 2026-02-19T03:28:46Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

lukstbit added the Needs Review label Dec 1, 2025

github-actions bot added the Strings label Dec 1, 2025

lukstbit force-pushed the feat_newFilteredDeckOptions branch from bd785df to 07b3bb3 Compare December 2, 2025 05:50

lukstbit force-pushed the feat_newFilteredDeckOptions branch from 07b3bb3 to 7026df5 Compare December 2, 2025 07:04

david-allison requested changes Dec 4, 2025

View reviewed changes

lukstbit force-pushed the feat_newFilteredDeckOptions branch 2 times, most recently from 0b62561 to 017c38d Compare December 6, 2025 14:54

david-allison approved these changes Dec 6, 2025

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/filtered/FilteredDeckOptionsFragment.kt Outdated Show resolved Hide resolved

david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 6, 2025

BrayanDSO mentioned this pull request Dec 7, 2025

feat: change themes configuration #19700

Merged

5 tasks

lukstbit force-pushed the feat_newFilteredDeckOptions branch from 017c38d to 8d788ed Compare December 7, 2025 14:17

mikehardy added the Blocked by dependency Currently blocked by some other dependent / related change label Dec 10, 2025

github-actions bot added the Has Conflicts label Dec 12, 2025

lukstbit force-pushed the feat_newFilteredDeckOptions branch from 8d788ed to 6c7eb7c Compare December 15, 2025 03:43

lukstbit removed the Has Conflicts label Dec 15, 2025

lukstbit removed the Blocked by dependency Currently blocked by some other dependent / related change label Dec 22, 2025

github-actions bot added the Has Conflicts label Jan 3, 2026

This was referenced Jan 5, 2026

fix: use standard res-auto namespace for app attributes #20022

Merged

code cleanup in FilteredDeckOptins.kt and AppcompatPreferenceActivity.kt #20047

Closed

Add url constant for ankiweb filtered decks related docs

38d464d

To be used in filtered decks options screen.

lukstbit added 4 commits January 12, 2026 15:12

Add implementation for new filtered deck options screen

660621e

Note: this doesn't implement completely the desktop functionality for this screen, everything missing will be added in a future PR.

Use new filtered deck options code

9e14d8d

Remove previous filtered deck options related code

68a26d0

lukstbit force-pushed the feat_newFilteredDeckOptions branch from 6c7eb7c to 68a26d0 Compare January 12, 2026 13:40

lukstbit removed the Has Conflicts label Jan 12, 2026

david-allison approved these changes Jan 12, 2026

View reviewed changes

github-actions bot added the Has Conflicts label Jan 12, 2026

david-allison mentioned this pull request Jan 13, 2026

Crash/Restart when switching apps while editing any field in Deck Options #20101

Closed

4 tasks

david-allison added the Review High Priority Request for high priority review label Jan 14, 2026

david-allison mentioned this pull request Jan 16, 2026

feat(fields): allow insertion of 'special fields' with preview #20041

Open

5 tasks

BrayanDSO requested changes Jan 16, 2026

View reviewed changes

BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jan 16, 2026

david-allison added this to the 2.24 release milestone Jan 21, 2026

This comment was marked as outdated.

Sign in to view

github-actions bot added the Stale label Feb 4, 2026

BrayanDSO removed the Stale label Feb 4, 2026

github-actions bot added the Stale label Feb 19, 2026

lukstbit removed the Stale label Feb 19, 2026

	// rescheduling(done here because in filter 2 setup we might exit early)
	// rescheduling (done here because in filter 2 setup we might exit early)

		private val did: DeckId
		get() = savedStateHandle.get<Long>(ARG_DECK_ID) ?: 0L

	* Represents the screen where a filtered deck can be built or rebuilt after updating it's properties.
	* Represents the screen where a filtered deck can be built or rebuilt after updating its properties.

Uh oh!

Comments

Conversation

lukstbit commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose / Description

Fixes

How Has This Been Tested?

Checklist

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

david-allison commented Dec 1, 2025

Uh oh!

ZornHadNoChoice commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukstbit commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZornHadNoChoice commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-allison commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukstbit commented Dec 6, 2025

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lukstbit commented Dec 7, 2025

Uh oh!

mikehardy commented Dec 10, 2025

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BrayanDSO commented Jan 16, 2026

Uh oh!

BrayanDSO commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrayanDSO left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukstbit commented Dec 1, 2025 •

edited

Loading

ZornHadNoChoice commented Dec 2, 2025 •

edited

Loading

lukstbit commented Dec 2, 2025 •

edited

Loading

ZornHadNoChoice commented Dec 2, 2025 •

edited

Loading

david-allison commented Dec 4, 2025 •

edited

Loading

BrayanDSO commented Jan 16, 2026 •

edited

Loading