Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Can't cache a namespace with spec defs #359

Closed
mfikes opened this issue Feb 19, 2018 · 5 comments
Closed

Can't cache a namespace with spec defs #359

mfikes opened this issue Feb 19, 2018 · 5 comments
Labels
upstream

Comments

@mfikes
Copy link
Collaborator

mfikes commented Feb 19, 2018

Presumably this will occur if Lumo is built against ClojureScript master:

planck-repl/planck#647
@arichiardi
Copy link
Collaborator

Oh the error is the same as in: #355

Will check that thank you!

@mfikes
Copy link
Collaborator Author

mfikes commented Feb 19, 2018

If you end up needing to work around the upstream transit-cljs issue, one trivial way to do so is to (clojure.walk/postwalk identity x) on x before passing it to the transit routines. (walk will inherently convert any map entries encountered to vectors)

@arichiardi
Copy link
Collaborator

Thanks I will probably have to!

arichiardi added a commit that referenced this issue Feb 20, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs map entry issue
ccbee35 
See also cognitect/transit-cljs#42.
arichiardi added a commit that referenced this issue Feb 20, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs map entry issue
09cac1f 
See also cognitect/transit-cljs#42.
arichiardi added a commit that referenced this issue Feb 20, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs map entry issue
348bcc9 
See also cognitect/transit-cljs#42.
arichiardi added a commit that referenced this issue Feb 20, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs map entry issue
2b43018 
See also cognitect/transit-cljs#42.
arichiardi added a commit that referenced this issue Feb 21, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs MapEntry issue
bb461d1 
See also cognitect/transit-cljs#42.
arichiardi added a commit that referenced this issue Feb 21, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs MapEntry issue
8cc2e32 
See also cognitect/transit-cljs#42.
@arichiardi arichiardi mentioned this issue Feb 21, 2018
Closed
arichiardi added a commit that referenced this issue Mar 24, 2018
@arichiardi
[Fix #359] Workaround the transit-cljs MapEntry issue
15a486a 
See also cognitect/transit-cljs#42.
@arichiardi arichiardi mentioned this issue Mar 24, 2018
Merged
@mfikes
Copy link
Collaborator Author

mfikes commented Mar 27, 2018

transit-cljs 0.8.248 is available with a fix for the upstream issue

@arichiardi
Copy link
Collaborator

Thanks Mike, will bump.

arichiardi added a commit that referenced this issue Mar 27, 2018
@arichiardi
[Fix #359] Use new transit-cljs with MapEntry writing support
1c0bc3e
arichiardi added a commit to arichiardi/lumo that referenced this issue Apr 3, 2018
@arichiardi
[Fix anmonteiro#359] Workaround the transit-cljs MapEntry issue
0bcb89c 
See also cognitect/transit-cljs#42.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfikes @arichiardi