This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Bundle cljs.core.specs.alpha #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
force-pushed
the
bundle-core-specs
branch
from
8e9046d to
5a2fe3a
Compare
|
It is indeed optional and will need manual inclusion via |
arichiardi
force-pushed
the
bundle-core-specs
branch
from
5a2fe3a to
6f93b98
Compare
arichiardi
changed the title
|
This PR is probably just good for making sure we include the files, therefore I am removing the WIP. |
arichiardi
changed the title
Cause cljs.core.specs.alpha is not required anywhere in core, it does not end up in the fileset (boot-cljs does not compile what is not depended upon). This means we need to sift it manually.
arichiardi
force-pushed
the
bundle-core-specs
branch
from
6f93b98 to
a657a12
Compare
|
What leads you to believe that these files are not already included? Did you look at the |
|
I checked that, see explanation in the PR 😄 |
|
We literally have |
|
Ok I will check again. |
|
I checked again and...you are right, I see it now in there. I had messed something up. Closing this. |
|
One problem though, I did: @anmonteiro should it be in |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course this fix cannot go in until the new version of ClojureScript is released containing clojure/clojurescript@9de75f3.
Cause
cljs.core.specs.alphais not required anywhere in core, it does not end up in the fileset (boot-cljsdoes not compile what is not depended upon).This means we need to
siftit manually.