Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in the Nockma prettyprinter and parser #2632

Merged
merged 9 commits into from
Feb 9, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Feb 8, 2024

This pr addresses a number of problems.

  1. It fixes a bug where paths were annotated as operations rather than paths in the parser.
  2. It fixes a bug that happened when unfolding cells in the pretty printer in order to minimize delimiters. It caused the stdlibcall hints to be ignored for the unfolded arguments.
  3. In order to properly test this, we can't ignore the hints for the Eq instance, so I've changed that.
  4. I've introduced the class NockmaEq for nockma semantic equality. This is used in the evaluator as well as in the semantic tests.
  5. I've added a bigger test. I found these bugs while working with this file.

@janmasrovira janmasrovira self-assigned this Feb 8, 2024
@janmasrovira janmasrovira changed the title Fix cell unfolding in Nockma prettyprinter Fix bugs in the Nockma prettyprinter and parser Feb 8, 2024
@janmasrovira janmasrovira force-pushed the fix-nockma-prettyprinter branch from 26664a7 to eedb4a8 Compare February 8, 2024 16:14
@janmasrovira janmasrovira marked this pull request as ready for review February 8, 2024 18:31
@janmasrovira janmasrovira force-pushed the fix-nockma-prettyprinter branch from eedb4a8 to c110771 Compare February 8, 2024 18:31
@paulcadman paulcadman force-pushed the fix-nockma-prettyprinter branch from c110771 to e6083f2 Compare February 9, 2024 12:28
@paulcadman paulcadman force-pushed the fix-nockma-prettyprinter branch from e6083f2 to 7807080 Compare February 9, 2024 12:42
@janmasrovira janmasrovira merged commit 50a62f6 into main Feb 9, 2024
4 checks passed
@janmasrovira janmasrovira deleted the fix-nockma-prettyprinter branch February 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants